From ad24596d3ffaeffce1579756d2874ddacefaaaf8 Mon Sep 17 00:00:00 2001 From: David Baker Date: Mon, 9 Nov 2015 13:48:05 +0000 Subject: [PATCH] Revert c13b180 as it fails lint (creating functions in a loop) --- lib/models/room.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/models/room.js b/lib/models/room.js index eff95ed79..ad586ff3f 100644 --- a/lib/models/room.js +++ b/lib/models/room.js @@ -375,13 +375,15 @@ Room.prototype.recalculate = function(userId) { var readReceiptsForEvent = this.getReceiptsForEvent(e); - readReceiptsForEvent.forEach(function(receipt) { - if (receipt.type !== "m.read") { return; } - if (usersFound[receipt.userId]) { return; } + for (var receiptIt = 0; receiptIt < readReceiptsForEvent.length; ++receiptIt) { + var receipt = readReceiptsForEvent[receiptIt]; + if (receipt.type !== "m.read") { continue; } + + if (usersFound[receipt.userId]) { continue; } // Then this is the receipt we keep for this user usersFound[receipt.userId] = 1; - }); + } if (e.sender && usersFound[e.sender.userId] === undefined) { // no receipt yet for this sender, so we synthesize one.