From a33e4477afdae65d7da9d059dd08da0b1007a2dc Mon Sep 17 00:00:00 2001 From: David Baker Date: Wed, 1 Mar 2017 16:35:37 +0000 Subject: [PATCH] Comment the ignoring of failures --- src/interactive-auth.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/interactive-auth.js b/src/interactive-auth.js index 2576bda24..3b31d3372 100644 --- a/src/interactive-auth.js +++ b/src/interactive-auth.js @@ -248,6 +248,9 @@ InteractiveAuth.prototype = { if (!ignoreFailure) { prom = prom.catch(this._completionDeferred.reject); } else { + // We ignore all failures here (even non-UI auth related ones) + // since we don't want to suddenly fail if the internet connection + // had a blip whilst we were polling prom = prom.catch((error) => { console.log("Ignoring error from UI auth: " + error); });