Refactor MatrixClient::forget to not abuse membershipChange API (#4490)

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

src/client.ts

@@ -5796,16 +5796,17 @@ export class MatrixClient extends TypedEventEmitter<EmittedEvents, ClientEventHa
      * @returns Promise which resolves: `{}` an empty object.
      * @returns Rejects: with an error response.
      */
-    public forget(roomId: string, deleteRoom = true): Promise<{}> {
+    public async forget(roomId: string, deleteRoom = true): Promise<{}> {
-        const promise = this.membershipChange(roomId, undefined, "forget");
+        // API returns an empty object
-        if (!deleteRoom) {
+        const path = utils.encodeUri("/rooms/$room_id/forget", {
-            return promise;
+            $room_id: roomId,
-        }
+        });
-        return promise.then((response) => {
+        const response = await this.http.authedRequest<{}>(Method.Post, path);
+        if (deleteRoom) {
             this.store.removeRoom(roomId);
             this.emit(ClientEvent.DeleteRoom, roomId);
+        }
         return response;
-        });
     }
 
     /**
@@ -5846,7 +5847,7 @@ export class MatrixClient extends TypedEventEmitter<EmittedEvents, ClientEventHa
     private membershipChange(
         roomId: string,
         userId: string | undefined,
-        membership: Membership | "forget",
+        membership: Membership,
         reason?: string,
     ): Promise<{}> {
         // API returns an empty object