matrix/matrix-js-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-js-sdk.git synced 2025-11-26 17:03:12 +03:00
Code Activity

Handle WebRTC security errors as non-fatal

Browse Source 
Fixes https://github.com/vector-im/riot-web/issues/10898

In some restricted modes of Firefox, the WebRTC classes aren't super available: accessing them can cause SecurityErrors to be raised. In these conditions, we should just disable WebRTC support instead of falling apart.
This commit is contained in:
Travis Ralston
2019-09-17 13:49:50 -06:00
parent 55b4595bbf
commit 565e18e8a3
1 changed files with 29 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/webrtc/call.js
View File

@@ -1370,6 +1370,12 @@ module.exports.createNewMatrixCall = function(client, roomId, options) {
return getUserMedia.apply(w.navigator, arguments); return getUserMedia.apply(w.navigator, arguments);
}; };
} }
// Firefox throws on so little as accessing the RTCPeerConnection when operating in
// a secure mode. There's some information at https://bugzilla.mozilla.org/show_bug.cgi?id=1542616
// though the concern is that the browser throwing a SecurityError will brick the
// client creation process.
try {
webRtc.RtcPeerConnection = ( webRtc.RtcPeerConnection = (
w.RTCPeerConnection || w.webkitRTCPeerConnection || w.mozRTCPeerConnection w.RTCPeerConnection || w.webkitRTCPeerConnection || w.mozRTCPeerConnection
); );
@@ -1388,6 +1394,12 @@ module.exports.createNewMatrixCall = function(client, roomId, options) {
} else if (w.RTCPeerConnection) { } else if (w.RTCPeerConnection) {
webRtc.vendor = "generic"; webRtc.vendor = "generic";
} }
} catch (e) {
logger.error("Failed to set up WebRTC object: possible browser interference?");
logger.error(e);
return null;
}
if (!webRtc.RtcIceCandidate || !webRtc.RtcSessionDescription || if (!webRtc.RtcIceCandidate || !webRtc.RtcSessionDescription ||
!webRtc.RtcPeerConnection || !webRtc.getUserMedia) { !webRtc.RtcPeerConnection || !webRtc.getUserMedia) {
return null; // WebRTC is not supported. return null; // WebRTC is not supported.