matrix/matrix-js-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-js-sdk.git synced 2025-12-04 05:02:41 +03:00
Code Activity

Fix threads reply count sometimes off by one (#2240)

Browse Source
This commit is contained in:
Germain
2022-03-16 00:59:12 +00:00
committed by GitHub
parent ee9eccb85a
commit 42b3b73551
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/models/thread.ts
View File

@@ -191,7 +191,10 @@ export class Thread extends TypedEventEmitter<EmittedEvents, EventHandlerMap> {
// There is a risk that the `localTimestamp` approximation will not be accurate // There is a risk that the `localTimestamp` approximation will not be accurate
// when threads are used over federation. That could results in the reply // when threads are used over federation. That could results in the reply
// count value drifting away from the value returned by the server // count value drifting away from the value returned by the server
if (!this.lastEvent || (isThreadReply && event.localTimestamp > this.lastEvent.localTimestamp)) { if (!this.lastEvent || (isThreadReply
&& (event.getId() !== this.lastEvent.getId())
&& (event.localTimestamp > this.lastEvent.localTimestamp))
) {
this.lastEvent = event; this.lastEvent = event;
if (this.lastEvent.getId() !== this.id) { if (this.lastEvent.getId() !== this.id) {
// This counting only works when server side support is enabled // This counting only works when server side support is enabled