1
0
mirror of https://github.com/matrix-org/matrix-js-sdk.git synced 2025-11-26 17:03:12 +03:00

review feedback

This commit is contained in:
Zoe
2020-02-05 09:57:46 +00:00
parent 18a2426707
commit 2b5de914f5

View File

@@ -28,7 +28,7 @@ import * as unhomoglyph from 'unhomoglyph';
* {"foo": "bar", "baz": "taz"}
* @return {string} The encoded string e.g. foo=bar&baz=taz
*/
export function encodeParams(params: {[key: string]: string}): string {
export function encodeParams(params: Record<string, string>): string {
let qs = "";
for (const key in params) {
if (!params.hasOwnProperty(key)) {
@@ -49,7 +49,7 @@ export function encodeParams(params: {[key: string]: string}): string {
* @return {string} The result of replacing all template variables e.g. '/foo/baz'.
*/
export function encodeUri(pathTemplate: string,
variables: {[key: string]: string}): string {
variables: Record<string, string>): string {
for (const key in variables) {
if (!variables.hasOwnProperty(key)) {
continue;
@@ -116,7 +116,7 @@ export function keys(obj: object): string[] {
* @param {Object} obj The object to get the values for.
* @return {Array<*>} The values of the object.
*/
export function values<T>(obj: {[keys: string]: T}): T[] {
export function values<T>(obj: Record<string, T>): T[] {
const values = [];
for (const key in obj) {
if (!obj.hasOwnProperty(key)) {