From 2a88b8db4e98aa95137a6689211300ba4aa1e5d7 Mon Sep 17 00:00:00 2001
From: Kegan Dougal <kegan@matrix.org>
Date: Wed, 20 Jan 2016 15:09:35 +0000
Subject: [PATCH] Improve performance of hasMembershipState to not be stupid

---
 lib/models/room.js | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lib/models/room.js b/lib/models/room.js
index 59d94d556..5b002613e 100644
--- a/lib/models/room.js
+++ b/lib/models/room.js
@@ -208,9 +208,11 @@ Room.prototype.getAvatarUrl = function(baseUrl, width, height, resizeMethod,
  * @return {boolean} True if this user_id has the given membership state.
  */
  Room.prototype.hasMembershipState = function(userId, membership) {
-    return utils.filter(this.currentState.getMembers(), function(m) {
-        return m.membership === membership && m.userId === userId;
-    }).length > 0;
+    var member = this.getMember(userId);
+    if (!member) {
+        return false;
+    }
+    return member.membership === membership;
  };
 
 /**