From 1889f8dad599201c9957cffcf3e22b12ec779b96 Mon Sep 17 00:00:00 2001
From: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Date: Mon, 20 Nov 2023 18:17:06 +0000
Subject: [PATCH] Reduce console log spam (#3896)

* Reduce console log spam

A couple of different things:

 * Increase the `MaxListeners` setting on `MatrixClient` and `Thread`, so that
   we don't get "possible EventEmitter leak" warnings

 * Disable a couple of warnings/info lines that are just part of regular
   operation and are logged in large volumes.

* another noisy log line

* Reinstate warning about receipts for missing events

Apparently this is being worked on
---
 src/client.ts                       | 3 +++
 src/models/thread.ts                | 3 +++
 src/rust-crypto/RoomEncryptor.ts    | 7 ++++---
 src/rust-crypto/rust-crypto.ts      | 4 ----
 src/webrtc/groupCallEventHandler.ts | 1 -
 5 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/src/client.ts b/src/client.ts
index 542f18515..e08e3bee7 100644
--- a/src/client.ts
+++ b/src/client.ts
@@ -1494,6 +1494,9 @@ export class MatrixClient extends TypedEventEmitter<EmittedEvents, ClientEventHa
 
         this.ignoredInvites = new IgnoredInvites(this);
         this._secretStorage = new ServerSideSecretStorageImpl(this, opts.cryptoCallbacks ?? {});
+
+        // having lots of event listeners is not unusual. 0 means "unlimited".
+        this.setMaxListeners(0);
     }
 
     public set store(newStore: Store) {
diff --git a/src/models/thread.ts b/src/models/thread.ts
index c405e21e2..244369557 100644
--- a/src/models/thread.ts
+++ b/src/models/thread.ts
@@ -143,6 +143,9 @@ export class Thread extends ReadReceipt<ThreadEmittedEvents, ThreadEventHandlerM
     public constructor(public readonly id: string, public rootEvent: MatrixEvent | undefined, opts: IThreadOpts) {
         super();
 
+        // each Event in the thread adds a reemitter, so we could hit the listener limit.
+        this.setMaxListeners(1000);
+
         if (!opts?.room) {
             // Logging/debugging for https://github.com/vector-im/element-web/issues/22141
             // Hope is that we end up with a more obvious stack trace.
diff --git a/src/rust-crypto/RoomEncryptor.ts b/src/rust-crypto/RoomEncryptor.ts
index 4ac808f6f..b16cfef87 100644
--- a/src/rust-crypto/RoomEncryptor.ts
+++ b/src/rust-crypto/RoomEncryptor.ts
@@ -64,12 +64,13 @@ export class RoomEncryptor {
         // start tracking devices for any users already known to be in this room.
         // Do not load members here, would defeat lazy loading.
         const members = room.getJoinedMembers();
+
         // At this point just mark the known members as tracked, it might not be the full list of members
         // because of lazy loading. This is fine, because we will get a member list update when sending a message for
         // the first time, see `RoomEncryptor#ensureEncryptionSession`
-        this.olmMachine.updateTrackedUsers(members.map((u) => new RustSdkCryptoJs.UserId(u.userId))).then(() => {
-            this.prefixedLogger.debug(`Updated tracked users for room ${room.roomId}`);
-        });
+        this.olmMachine
+            .updateTrackedUsers(members.map((u) => new RustSdkCryptoJs.UserId(u.userId)))
+            .catch((e) => this.prefixedLogger.error("Error initializing tracked users", e));
     }
 
     /**
diff --git a/src/rust-crypto/rust-crypto.ts b/src/rust-crypto/rust-crypto.ts
index fde74fe90..f0c3c8973 100644
--- a/src/rust-crypto/rust-crypto.ts
+++ b/src/rust-crypto/rust-crypto.ts
@@ -1560,10 +1560,6 @@ class EventDecryptor {
     ) {}
 
     public async attemptEventDecryption(event: MatrixEvent): Promise<IEventDecryptionResult> {
-        this.logger.info(
-            `Attempting decryption of event ${event.getId()} in ${event.getRoomId()} from ${event.getSender()}`,
-        );
-
         // add the event to the pending list *before* attempting to decrypt.
         // then, if the key turns up while decryption is in progress (and
         // decryption fails), we will schedule a retry.
diff --git a/src/webrtc/groupCallEventHandler.ts b/src/webrtc/groupCallEventHandler.ts
index 3dae0ce40..2db54f66b 100644
--- a/src/webrtc/groupCallEventHandler.ts
+++ b/src/webrtc/groupCallEventHandler.ts
@@ -133,7 +133,6 @@ export class GroupCallEventHandler {
             break;
         }
 
-        logger.debug(`GroupCallEventHandler createGroupCallForRoom() processed room (roomId=${room.roomId})`);
         this.getRoomDeferred(room.roomId).resolve!();
     }