From 86e73bdd35e688def55feb96af6cb8620b1ef62e Mon Sep 17 00:00:00 2001 From: Erik Johnston Date: Tue, 21 Jul 2015 15:31:58 +0100 Subject: [PATCH 1/2] Add getMembersWithMembership to get all members with given membership state --- lib/models/room.js | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/lib/models/room.js b/lib/models/room.js index 74ddcad50..370cd6e34 100644 --- a/lib/models/room.js +++ b/lib/models/room.js @@ -61,6 +61,17 @@ utils.inherits(Room, EventEmitter); }); }; +/** + * Get a list of members with given membership state. + * @param {string} membership The membership state. + * @return {RoomMember[]} A list of members with the given membership state. + */ + Room.prototype.getMembersWithMemership = function(membership) { + return utils.filter(this.currentState.getMembers(), function(m) { + return m.membership === membership; + }); + }; + /** * Check if the given user_id has the given membership state. * @param {string} userId The user ID to check. From f716431f6588a4a2929d22c7a6255dac509a4f53 Mon Sep 17 00:00:00 2001 From: Erik Johnston Date: Tue, 21 Jul 2015 15:41:33 +0100 Subject: [PATCH 2/2] Make getJoinedUsers call getMembersWithMembership --- lib/models/room.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/models/room.js b/lib/models/room.js index 370cd6e34..c5b5623ee 100644 --- a/lib/models/room.js +++ b/lib/models/room.js @@ -56,9 +56,7 @@ utils.inherits(Room, EventEmitter); * @return {RoomMember[]} A list of currently joined members. */ Room.prototype.getJoinedMembers = function() { - return utils.filter(this.currentState.getMembers(), function(m) { - return m.membership === "join"; - }); + return this.getMembersWithMemership("join"); }; /**