You've already forked element-web
mirror of
https://github.com/element-hq/element-web.git
synced 2025-08-02 07:06:40 +03:00
* implement basic scrolling and keyboard navigation * Update focus style and improve keyboard navigation * lint * Use avatar tootltip for the title rather than the whole button It's more performant and feels less glitchy than the button tooltip moving around when you scroll. * lint * Add tooltip for invite buttons active state As we have for other icon based buttons in the right panel/app * Fix location of scrollToIndex and add useCallback * Improve voiceover experience - As well as stylng cells, set the tabIndex(roving) - Natively focus the div with .focus() so screen reader actually moves over the cells - improve labels and roles * Fix jest tests * Add aria index/counts and remove repeating "Open" string in label * update snapshot * Add the rest of the keyboard navigation and handle the case when the list looses focus. * lint and update snapshot * lint * Only focus first/lastFocsed cell if focus.currentTarget is the overall list. So it isn't erroneously called during onClick of an item. * Put back overscan and fix formatting * Extract ListView out of MemberList * lint and fix e2e test * Update screenshot It looks like it is slightly better center aligned in the new list, as if maybe it was 1 px to high with the old one. * Fix default overscan value and add ListView tests * Just leave the avatar as it was * We removed the tooltip that showed power level. Removing string. * Use key rather than index to track focus. * Remove overscan, fix typos, fix scrollToItem logic * Use listbox role for member list and correct position/count values to account for the separator * Fix inadvertant scrolling of the timeline when using pageUp/pageDown * Always set the roving tab index regardless of whether we are actually focused. Fixes the issue of not being able to shift+t * Add aria-hidden to items within the option to avoid the SR calling it a group. Also * Make sure there is a roving tab set if the last one has been removed from the list. * Update snapshot
152 lines
5.7 KiB
TypeScript
152 lines
5.7 KiB
TypeScript
/*
|
|
Copyright 2024 New Vector Ltd.
|
|
Copyright 2023 The Matrix.org Foundation C.I.C.
|
|
|
|
SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Commercial
|
|
Please see LICENSE files in the repository root for full details.
|
|
*/
|
|
|
|
import { Bot } from "../../pages/bot";
|
|
import type { Locator, Page } from "@playwright/test";
|
|
import type { ElementAppPage } from "../../pages/ElementAppPage";
|
|
import { test, expect } from "../../element-web-test";
|
|
import { type Credentials } from "../../plugins/homeserver";
|
|
import { isDendrite } from "../../plugins/homeserver/dendrite";
|
|
|
|
test.describe("Lazy Loading", () => {
|
|
test.skip(isDendrite, "due to a Dendrite bug https://github.com/element-hq/dendrite/issues/3488");
|
|
|
|
const charlies: Bot[] = [];
|
|
|
|
test.use({
|
|
displayName: "Alice",
|
|
botCreateOpts: { displayName: "Bob" },
|
|
});
|
|
|
|
test.beforeEach(async ({ page }) => {
|
|
await page.addInitScript(() => {
|
|
window.localStorage.setItem("mx_lhs_size", "0"); // Collapse left panel for these tests
|
|
});
|
|
});
|
|
|
|
test.beforeEach(async ({ page, homeserver, user, bot, app }) => {
|
|
// The charlies were running off the bottom of the screen.
|
|
// We no longer overscan the member list so the result is they are not in the dom.
|
|
// Increase the viewport size to ensure they are.
|
|
await page.setViewportSize({ width: 1000, height: 1000 });
|
|
for (let i = 1; i <= 10; i++) {
|
|
const displayName = `Charly #${i}`;
|
|
const bot = new Bot(page, homeserver, { displayName, startClient: false, autoAcceptInvites: false });
|
|
charlies.push(bot);
|
|
}
|
|
await app.client.network.setupRoute();
|
|
});
|
|
|
|
const name = "Lazy Loading Test";
|
|
const charlyMsg1 = "hi bob!";
|
|
const charlyMsg2 = "how's it going??";
|
|
let roomId: string;
|
|
|
|
async function setupRoomWithBobAliceAndCharlies(
|
|
page: Page,
|
|
app: ElementAppPage,
|
|
user: Credentials,
|
|
bob: Bot,
|
|
charlies: Bot[],
|
|
) {
|
|
const alias = `#lltest:${user.homeServer}`;
|
|
const visibility = await page.evaluate(() => (window as any).matrixcs.Visibility.Public);
|
|
roomId = await bob.createRoom({
|
|
name,
|
|
room_alias_name: "lltest",
|
|
visibility,
|
|
});
|
|
|
|
await Promise.all(charlies.map((bot) => bot.joinRoom(alias)));
|
|
for (const charly of charlies) {
|
|
await charly.sendMessage(roomId, charlyMsg1);
|
|
}
|
|
for (const charly of charlies) {
|
|
await charly.sendMessage(roomId, charlyMsg2);
|
|
}
|
|
|
|
for (let i = 20; i >= 1; --i) {
|
|
await bob.sendMessage(roomId, `I will only say this ${i} time(s)!`);
|
|
}
|
|
await app.client.joinRoom(alias);
|
|
await app.viewRoomByName(name);
|
|
}
|
|
|
|
async function checkPaginatedDisplayNames(app: ElementAppPage, charlies: Bot[]) {
|
|
await app.timeline.scrollToTop();
|
|
for (const charly of charlies) {
|
|
await expect(await app.timeline.findEventTile(charly.credentials.displayName, charlyMsg1)).toBeAttached();
|
|
await expect(await app.timeline.findEventTile(charly.credentials.displayName, charlyMsg2)).toBeAttached();
|
|
}
|
|
}
|
|
|
|
async function openMemberlist(app: ElementAppPage): Promise<void> {
|
|
await app.toggleRoomInfoPanel();
|
|
const { page } = app;
|
|
await page.locator(".mx_RightPanel").getByRole("menuitem", { name: "People" }).click();
|
|
}
|
|
|
|
function getMemberInMemberlist(page: Page, name: string): Locator {
|
|
return page.locator(".mx_MemberListView .mx_MemberTileView_name").filter({ hasText: name });
|
|
}
|
|
|
|
async function checkMemberList(page: Page, charlies: Bot[]) {
|
|
await expect(getMemberInMemberlist(page, "Alice")).toBeAttached();
|
|
await expect(getMemberInMemberlist(page, "Bob")).toBeAttached();
|
|
for (const charly of charlies) {
|
|
await expect(getMemberInMemberlist(page, charly.credentials.displayName)).toBeAttached();
|
|
}
|
|
}
|
|
|
|
async function checkMemberListLacksCharlies(page: Page, charlies: Bot[]) {
|
|
for (const charly of charlies) {
|
|
await expect(getMemberInMemberlist(page, charly.credentials.displayName)).not.toBeAttached();
|
|
}
|
|
}
|
|
|
|
async function joinCharliesWhileAliceIsOffline(
|
|
page: Page,
|
|
app: ElementAppPage,
|
|
user: Credentials,
|
|
charlies: Bot[],
|
|
) {
|
|
const alias = `#lltest:${user.homeServer}`;
|
|
await app.client.network.goOffline();
|
|
for (const charly of charlies) {
|
|
await charly.joinRoom(alias);
|
|
}
|
|
for (let i = 20; i >= 1; --i) {
|
|
await charlies[0].sendMessage(roomId, "where is charly?");
|
|
}
|
|
await app.client.network.goOnline();
|
|
await app.client.waitForNextSync();
|
|
}
|
|
|
|
test("should handle lazy loading properly even when offline", async ({ page, app, bot, user }) => {
|
|
test.slow();
|
|
const charly1to5 = charlies.slice(0, 5);
|
|
const charly6to10 = charlies.slice(5);
|
|
|
|
// Set up room with alice, bob & charlies 1-5
|
|
await setupRoomWithBobAliceAndCharlies(page, app, user, bot, charly1to5);
|
|
// Alice should see 2 messages from every charly with the correct display name
|
|
await checkPaginatedDisplayNames(app, charly1to5);
|
|
|
|
await openMemberlist(app);
|
|
await checkMemberList(page, charly1to5);
|
|
await joinCharliesWhileAliceIsOffline(page, app, user, charly6to10);
|
|
await checkMemberList(page, charly6to10);
|
|
|
|
for (const charly of charlies) {
|
|
await charly.evaluate((client, roomId) => client.leave(roomId), roomId);
|
|
}
|
|
|
|
await checkMemberListLacksCharlies(page, charlies);
|
|
});
|
|
});
|