Be consistent when logging errors

crates/storage/src/oauth2/access_token.rs

@@ -30,7 +30,7 @@ use crate::{Clock, DatabaseError, DatabaseInconsistencyError};
         user.id = %session.browser_session.user.id,
         access_token.id,
     ),
-    err(Debug),
+    err,
 )]
 pub async fn add_access_token(
     executor: impl PgExecutor<'_>,

crates/storage/src/oauth2/refresh_token.rs

@@ -33,7 +33,7 @@ use crate::{Clock, DatabaseError, DatabaseInconsistencyError};
         client.id = %session.client.id,
         refresh_token.id,
     ),
-    err(Debug),
+    err,
 )]
 pub async fn add_refresh_token(
     executor: impl PgExecutor<'_>,
@@ -259,7 +259,7 @@ pub async fn lookup_active_refresh_token(
     fields(
         %refresh_token.id,
     ),
-    err(Debug),
+    err,
 )]
 pub async fn consume_refresh_token(
     executor: impl PgExecutor<'_>,

crates/storage/src/upstream_oauth2/link.rs

@@ -198,7 +198,7 @@ pub async fn associate_link_to_user(
 #[tracing::instrument(
     skip_all,
     fields(%user.id, %user.username),
-    err(Display)
+    err
 )]
 pub async fn get_paginated_user_links(
     executor: impl PgExecutor<'_>,

crates/storage/src/user/mod.rs

@@ -695,7 +695,7 @@ pub async fn add_user_email(
         %user_email.id,
         %user_email.email,
     ),
-    err(Display),
+    err,
 )]
 pub async fn set_user_email_as_primary(
     executor: impl PgExecutor<'_>,