matrix/authentication-service
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-authentication-service.git synced 2025-08-09 04:22:45 +03:00
Code Activity

jose: Reduce stack size of JsonWebSignatureHeader

Browse Source 
… by putting the optional jwk field behind a box.

The overall size will be one pointer larger when the field is Some(_),
but more than 300 bytes small when it is None.
This commit is contained in:
Jonas Platte
2023-11-03 13:25:27 +01:00
committed by Quentin Gliech
parent 464eeda3f3
commit 520357e78b
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
crates/jose/src/jwt/header.rs
View File

@@ -28,7 +28,7 @@ pub struct JsonWebSignatureHeader {
jku: Option<Url>, jku: Option<Url>,
#[serde(default)] #[serde(default)]
jwk: Option<PublicJsonWebKey>, jwk: Option<Box<PublicJsonWebKey>>,
#[serde(default)] #[serde(default)]
kid: Option<String>, kid: Option<String>,
@@ -91,12 +91,16 @@ impl JsonWebSignatureHeader {
#[must_use] #[must_use]
pub const fn jwk(&self) -> Option<&PublicJsonWebKey> { pub const fn jwk(&self) -> Option<&PublicJsonWebKey> {
self.jwk.as_ref() // Can't use as_deref because it's not a const fn
match &self.jwk {
Some(jwk) => Some(jwk),
None => None,
}
} }
#[must_use] #[must_use]
pub fn with_jwk(mut self, jwk: PublicJsonWebKey) -> Self { pub fn with_jwk(mut self, jwk: PublicJsonWebKey) -> Self {
self.jwk = Some(jwk); self.jwk = Some(Box::new(jwk));
self self
} }