Tidy up upstream linking templates

crates/handlers/src/upstream_oauth2/link.rs

@@ -34,7 +34,10 @@ use mas_storage::{
     },
     LookupResultExt,
 };
-use mas_templates::{EmptyContext, TemplateContext, Templates, UpstreamExistingLinkContext};
+use mas_templates::{
+    EmptyContext, TemplateContext, Templates, UpstreamExistingLinkContext, UpstreamRegister,
+    UpstreamSuggestLink,
+};
 use serde::Deserialize;
 use sqlx::PgPool;
 use thiserror::Error;
@@ -174,7 +177,7 @@ pub(crate) async fn get(
 
         (Some(user_session), None) => {
             // Session not linked, but user logged in: suggest linking account
-            let ctx = EmptyContext
+            let ctx = UpstreamSuggestLink::new(link.id)
                 .with_session(user_session)
                 .with_csrf(csrf_token.form_value());
 
@@ -193,7 +196,7 @@ pub(crate) async fn get(
         (None, None) => {
             // Session not linked and used not logged in: suggest creating an
             // account or logging in an existing user
-            let ctx = EmptyContext.with_csrf(csrf_token.form_value());
+            let ctx = UpstreamRegister::new(link.id).with_csrf(csrf_token.form_value());
 
             templates.render_upstream_oauth2_do_register(&ctx).await?
         }

crates/handlers/src/views/logout.rs

@@ -48,10 +48,10 @@ pub(crate) async fn post(
     txn.commit().await?;
 
     let destination = if let Some(action) = form {
-        mas_router::Login::and_then(action)
+        action.go_next()
     } else {
-        mas_router::Login::default()
+        mas_router::Login::default().go()
     };
 
-    Ok((cookie_jar, destination.go()))
+    Ok((cookie_jar, destination))
 }

crates/handlers/src/views/shared.rs

@@ -47,12 +47,27 @@ impl OptionalPostAuthAction {
                 let grant = Box::new(grant.into());
                 Ok(Some(PostAuthContext::ContinueAuthorizationGrant { grant }))
             }
+
             Some(PostAuthAction::ContinueCompatSsoLogin { data }) => {
                 let login = get_compat_sso_login_by_id(conn, *data).await?;
                 let login = Box::new(login.into());
                 Ok(Some(PostAuthContext::ContinueCompatSsoLogin { login }))
             }
+
             Some(PostAuthAction::ChangePassword) => Ok(Some(PostAuthContext::ChangePassword)),
+
+            Some(PostAuthAction::LinkUpstream { id }) => {
+                let (link, provider_id, _user_id) =
+                    mas_storage::upstream_oauth2::lookup_link(&mut *conn, *id).await?;
+
+                let provider =
+                    mas_storage::upstream_oauth2::lookup_provider(&mut *conn, provider_id).await?;
+
+                let provider = Box::new(provider);
+                let link = Box::new(link);
+                Ok(Some(PostAuthContext::LinkUpstream { provider, link }))
+            }
+
             None => Ok(None),
         }
     }

crates/router/src/endpoints.rs

@@ -31,6 +31,10 @@ pub enum PostAuthAction {
         data: Ulid,
     },
     ChangePassword,
+    LinkUpstream {
+        #[serde_as(as = "DisplayFromStr")]
+        id: Ulid,
+    },
 }
 
 impl PostAuthAction {
@@ -49,6 +53,7 @@ impl PostAuthAction {
             Self::ContinueAuthorizationGrant { data } => ContinueAuthorizationGrant(*data).go(),
             Self::ContinueCompatSsoLogin { data } => CompatLoginSsoComplete::new(*data, None).go(),
             Self::ChangePassword => AccountPassword.go(),
+            Self::LinkUpstream { id } => UpstreamOAuth2Link::new(*id).go(),
         }
     }
 }

crates/templates/src/context.rs

@@ -18,10 +18,10 @@
 
 use chrono::Utc;
 use mas_data_model::{
-    AuthorizationGrant, BrowserSession, CompatSsoLogin, CompatSsoLoginState, StorageBackend, User,
-    UserEmail, UserEmailVerification,
+    AuthorizationGrant, BrowserSession, CompatSsoLogin, CompatSsoLoginState, StorageBackend,
+    UpstreamOAuthLink, UpstreamOAuthProvider, User, UserEmail, UserEmailVerification,
 };
-use mas_router::PostAuthAction;
+use mas_router::{PostAuthAction, Route};
 use serde::{ser::SerializeStruct, Deserialize, Serialize};
 use ulid::Ulid;
 use url::Url;
@@ -263,6 +263,15 @@ pub enum PostAuthContext {
 
     /// Change the account password
     ChangePassword,
+
+    /// Link an upstream account
+    LinkUpstream {
+        /// The upstream provider
+        provider: Box<UpstreamOAuthProvider>,
+
+        /// The link
+        link: Box<UpstreamOAuthLink>,
+    },
 }
 
 /// Context used by the `login.html` template
@@ -779,6 +788,57 @@ impl TemplateContext for UpstreamExistingLinkContext {
     }
 }
 
+/// Context used by the `pages/upstream_oauth2/suggest_link.html`
+/// templates
+#[derive(Serialize)]
+pub struct UpstreamSuggestLink {
+    post_logout_action: PostAuthAction,
+}
+
+impl UpstreamSuggestLink {
+    /// Constructs a new context with an existing linked user
+    #[must_use]
+    pub fn new(link_id: Ulid) -> Self {
+        let post_logout_action = PostAuthAction::LinkUpstream { id: link_id };
+        Self { post_logout_action }
+    }
+}
+
+impl TemplateContext for UpstreamSuggestLink {
+    fn sample(_now: chrono::DateTime<Utc>) -> Vec<Self>
+    where
+        Self: Sized,
+    {
+        vec![Self::new(Ulid::nil())]
+    }
+}
+
+/// Context used by the `pages/upstream_oauth2/do_register.html`
+/// templates
+#[derive(Serialize)]
+pub struct UpstreamRegister {
+    login_link: String,
+}
+
+impl UpstreamRegister {
+    /// Constructs a new context with an existing linked user
+    #[must_use]
+    pub fn new(link_id: Ulid) -> Self {
+        let action = PostAuthAction::LinkUpstream { id: link_id };
+        let login_link = mas_router::Login::and_then(action).relative_url().into();
+        Self { login_link }
+    }
+}
+
+impl TemplateContext for UpstreamRegister {
+    fn sample(_now: chrono::DateTime<Utc>) -> Vec<Self>
+    where
+        Self: Sized,
+    {
+        vec![Self::new(Ulid::nil())]
+    }
+}
+
 /// Context used by the `form_post.html` template
 #[derive(Serialize)]
 pub struct FormPostContext<T> {

crates/templates/src/lib.rs

@@ -49,7 +49,8 @@ pub use self::{
         EmailVerificationContext, EmailVerificationPageContext, EmptyContext, ErrorContext,
         FormPostContext, IndexContext, LoginContext, LoginFormField, PolicyViolationContext,
         PostAuthContext, ReauthContext, ReauthFormField, RegisterContext, RegisterFormField,
-        TemplateContext, UpstreamExistingLinkContext, WithCsrf, WithOptionalSession, WithSession,
+        TemplateContext, UpstreamExistingLinkContext, UpstreamRegister, UpstreamSuggestLink,
+        WithCsrf, WithOptionalSession, WithSession,
     },
     forms::{FieldError, FormError, FormField, FormState, ToFormState},
 };
@@ -233,13 +234,13 @@ register_templates! {
     pub fn render_upstream_oauth2_link_mismatch(WithCsrf<WithSession<UpstreamExistingLinkContext>>) { "pages/upstream_oauth2/link_mismatch.html" }
 
     /// Render the upstream suggest link message
-    pub fn render_upstream_oauth2_suggest_link(WithCsrf<WithSession<EmptyContext>>) { "pages/upstream_oauth2/suggest_link.html" }
+    pub fn render_upstream_oauth2_suggest_link(WithCsrf<WithSession<UpstreamSuggestLink>>) { "pages/upstream_oauth2/suggest_link.html" }
 
     /// Render the upstream login screen
     pub fn render_upstream_oauth2_do_login(WithCsrf<UpstreamExistingLinkContext>) { "pages/upstream_oauth2/do_login.html" }
 
     /// Render the upstream register screen
-    pub fn render_upstream_oauth2_do_register(WithCsrf<EmptyContext>) { "pages/upstream_oauth2/do_register.html" }
+    pub fn render_upstream_oauth2_do_register(WithCsrf<UpstreamRegister>) { "pages/upstream_oauth2/do_register.html" }
 }
 
 impl Templates {

templates/components/field.html

@@ -29,10 +29,10 @@ limitations under the License.
     {% set text_color = "text-black-800 dark:text-grey-300" %}
   {% endif %}
 
-  <label class="flex flex-col block {{ class }}">
-    <div class="mx-2 -mb-3 -mt-2 leading-5 px-1 z-10 self-start bg-white dark:bg-black-900 border-white border-1 dark:border-2 dark:border-black-900 rounded-full text-sm {{ text_color }}">{{ label }}</div>
+  <label class="flex flex-col {{ class }}">
+    <div class="mx-2 -mb-3 -mt-2 leading-5 px-1 z-10 self-start bg-white dark:bg-black-900 border-white border-2 dark:border-black-900 rounded-full text-sm {{ text_color }}">{{ label }}</div>
     <input name="{{ name }}"
-      class="z-0 px-3 py-2 bg-white dark:bg-black-900 rounded-lg {{ border_color }} border-1 dark:border-2 focus:border-accent focus:ring-0 focus:outline-0"
+      class="z-0 px-3 py-2 bg-white dark:bg-black-900 rounded-lg {{ border_color }} border-2 focus:border-accent focus:ring-0 focus:outline-0"
       type="{{ type }}" 
       inputmode="{{ inputmode }}"
       {% if autocomplete %} autocomplete="{{ autocomplete }}" {% endif %} 

templates/pages/login.html

@@ -19,10 +19,18 @@ limitations under the License.
 {% block content %}
   <section class="flex items-center justify-center flex-1">
     <form method="POST" class="grid grid-cols-1 gap-6 w-96 m-2">
-      <div class="text-center">
-        <h1 class="text-lg text-center font-medium">Sign in</h1>
-        <p>Please sign in to continue:</p>
-      </div>
+      {% if next and next.kind == "link_upstream" %}
+        <div class="text-center">
+          <h1 class="text-lg text-center font-medium">Sign in to link</h1>
+          <p class="text-sm">Linking your <span class="break-keep text-links">{{ next.provider.issuer }}</span> account</p>
+        </div>
+      {% else %}
+        <div class="text-center">
+          <h1 class="text-lg text-center font-medium">Sign in</h1>
+          <p>Please sign in to continue:</p>
+        </div>
+      {% endif %}
+
       {% if form.errors is not empty %}
         {% for error in form.errors %}
           <div class="text-alert font-medium">
@@ -50,10 +58,13 @@ limitations under the License.
           {{ button::button(text="Next") }}
         </div>
       {% endif %}
-      <div class="text-center mt-4">
-        Don't have an account yet?
-        {{ button::link_text(text="Create an account", href=register_link) }}
-      </div>
+
+      {% if not next or next.kind != "link_upstream" %}
+        <div class="text-center mt-4">
+          Don't have an account yet?
+          {{ button::link_text(text="Create an account", href=register_link) }}
+        </div>
+      {% endif %}
     </form>
   </section>
 {% endblock content %}

templates/pages/upstream_oauth2/do_login.html

@@ -19,10 +19,27 @@ limitations under the License.
 {% block content %}
   <section class="flex items-center justify-center flex-1">
     <form method="POST" class="grid grid-cols-1 gap-6 w-96">
-      <h1 class="rounded-lg bg-grey-25 dark:bg-grey-450 p-2 flex flex-col font-medium text-lg text-center">
+      <h1 class="rounded-lg bg-grey-25 dark:bg-grey-450 p-2 font-medium text-lg text-center">
         Continue login
       </h1>
 
+      <div class="rounded-lg bg-grey-25 dark:bg-grey-450 p-4 flex flex-col">
+        <div>
+          Username: <span class="font-medium">{{ linked_user.username }}</span>
+        </div>
+        <div class="text-sm">
+          Identifier: <span class="font-mono font-medium">{{ linked_user.sub }}</span>
+        </div>
+        <div class="text-sm">
+          Primary email:
+          {% if linked_user.primary_email %}
+            <span class="font-medium">{{ linked_user.primary_email.email }}</span>
+          {% else %}
+            <span class="italic">none</span>
+          {% endif %}
+        </div>
+      </div>
+
       <input type="hidden" name="csrf" value="{{ csrf_token }}" />
       <input type="hidden" name="action" value="login" />
 

templates/pages/upstream_oauth2/do_register.html

@@ -18,16 +18,24 @@ limitations under the License.
 
 {% block content %}
   <section class="flex items-center justify-center flex-1">
-    <form method="POST" class="grid grid-cols-1 gap-6 w-96">
-      <h1 class="rounded-lg bg-grey-25 dark:bg-grey-450 p-2 flex flex-col font-medium text-lg text-center">
-        Choose your username
-      </h1>
+    <div class="grid grid-cols-1 gap-6 w-96">
+      <form method="POST" class="grid grid-cols-1 gap-6">
+        <h1 class="rounded-lg bg-grey-25 dark:bg-grey-450 p-2 text-center font-medium text-lg">
+          Choose your username
+        </h1>
 
-      <input type="hidden" name="csrf" value="{{ csrf_token }}" />
-      <input type="hidden" name="action" value="register" />
-      {{ field::input(label="Username", name="username", autocomplete="username", autocorrect="off", autocapitalize="none") }}
+        <input type="hidden" name="csrf" value="{{ csrf_token }}" />
+        <input type="hidden" name="action" value="register" />
+        {{ field::input(label="Username", name="username", autocomplete="username", autocorrect="off", autocapitalize="none") }}
 
-      {{ button::button(text="Continue") }}
-    </form>
+        {{ button::button(text="Create a new account") }}
+      </form>
+      <div class="flex items-center">
+        <hr class="flex-1" />
+        <div class="mx-2">Or</div>
+        <hr class="flex-1" />
+      </div>
+      {{ button::link_outline(text="Link to an existing account", href=login_link) }}
+    </div>
   </section>
 {% endblock content %}

templates/pages/upstream_oauth2/link_mismatch.html

@@ -24,7 +24,7 @@ limitations under the License.
         This upstream account is already linked to another account.
       </h1>
 
-      {{ logout::button(text="Logout", class=button::plain_class(), csrf_token=csrf_token) }}
+      <div>{{ logout::button(text="Logout", class=button::outline_class(), csrf_token=csrf_token) }}</div>
     </div>
   </section>
 {% endblock content %}

templates/pages/upstream_oauth2/suggest_link.html

@@ -31,7 +31,7 @@ limitations under the License.
         {{ button::button(text="Link", class="flex-1") }}
       </form>
 
-      <div>Or {{ logout::button(text="Logout", class=button::outline_class(), csrf_token=csrf_token) }}</div>
+      <div>Or {{ logout::button(text="Logout", class=button::outline_class(), csrf_token=csrf_token, post_logout_action=post_logout_action) }}</div>
     </div>
   </section>
 {% endblock content %}