lib/zstd
1
0
Fork 0
mirror of https://github.com/facebook/zstd.git synced 2025-07-30 22:23:13 +03:00
Code Activity

fix potential leak on exit

Browse Source
This commit is contained in:
Yann Collet
2021-03-02 15:03:37 -08:00
parent ce6d1b9376
commit a80b10f5e6
1 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
contrib/seekable_format/zstdseek_decompress.c
View File

@ -195,26 +195,22 @@ size_t ZSTD_seekable_free(ZSTD_seekable* zs)
ZSTD_freeDStream(zs->dstream); ZSTD_freeDStream(zs->dstream);
free(zs->seekTable.entries); free(zs->seekTable.entries);
free(zs); free(zs);
return 0; return 0;
} }
size_t ZSTD_seekable_copySeekTable(ZSTD_seekable* zs, ZSTD_seekTable** out) size_t ZSTD_seekable_copySeekTable(ZSTD_seekable* zs, ZSTD_seekTable** out)
{ {
ZSTD_seekTable* st = malloc(sizeof(ZSTD_seekTable)); ZSTD_seekTable* const st = malloc(sizeof(ZSTD_seekTable));
if (!st) { if (st==NULL) return ERROR(memory_allocation);
free(st);
return ERROR(memory_allocation);
}
st->checksumFlag = zs->seekTable.checksumFlag; st->checksumFlag = zs->seekTable.checksumFlag;
st->tableLen = zs->seekTable.tableLen; st->tableLen = zs->seekTable.tableLen;
/* Allocate an extra entry at the end to match logic of initial allocation */ /* Allocate an extra entry at the end to match logic of initial allocation */
size_t entriesSize = sizeof(seekEntry_t) * (zs->seekTable.tableLen + 1); size_t entriesSize = sizeof(seekEntry_t) * (zs->seekTable.tableLen + 1);
seekEntry_t* entries = (seekEntry_t*)malloc(entriesSize); seekEntry_t* const entries = (seekEntry_t*)malloc(entriesSize);
if (!entries) { if (entries==NULL) {
free(entries); free(st);
return ERROR(memory_allocation); return ERROR(memory_allocation);
} }
@ -230,7 +226,6 @@ size_t ZSTD_seekTable_free(ZSTD_seekTable* st)
if (st == NULL) return 0; /* support free on null */ if (st == NULL) return 0; /* support free on null */
free(st->entries); free(st->entries);
free(st); free(st);
return 0; return 0;
} }