From 495dcb839ab6ab40c4156b99be16b010389f2214 Mon Sep 17 00:00:00 2001 From: Nick Terrell Date: Thu, 20 Jan 2022 22:45:03 -0800 Subject: [PATCH] [zstdcli] Fix option detection for --auto-threads The option `--auto-threads` should still be accepted and parsed, even if `ZSTD_MULTITHREAD` is not defined. It doesn't mean anything, but we should still accept the option. Since we want scripts to be able to work generically. This bug was caught by tests I added to the new testing framework. --- programs/zstdcli.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/programs/zstdcli.c b/programs/zstdcli.c index fd563e1c2..53b47f874 100644 --- a/programs/zstdcli.c +++ b/programs/zstdcli.c @@ -802,9 +802,7 @@ int main(int argCount, const char* argv[]) separateFiles = 0, setRealTimePrio = 0, singleThread = 0, -#ifdef ZSTD_MULTITHREAD defaultLogicalCores = 0, -#endif showDefaultCParams = 0, ultra=0, contentSize=1; @@ -996,7 +994,6 @@ int main(int argCount, const char* argv[]) if (longCommandWArg(&argument, "--target-compressed-block-size=")) { targetCBlockSize = readSizeTFromChar(&argument); continue; } if (longCommandWArg(&argument, "--size-hint=")) { srcSizeHint = readSizeTFromChar(&argument); continue; } if (longCommandWArg(&argument, "--output-dir-flat")) { NEXT_FIELD(outDirName); continue; } -#ifdef ZSTD_MULTITHREAD if (longCommandWArg(&argument, "--auto-threads")) { const char* threadDefault = NULL; NEXT_FIELD(threadDefault); @@ -1004,7 +1001,6 @@ int main(int argCount, const char* argv[]) defaultLogicalCores = 1; continue; } -#endif #ifdef UTIL_HAS_MIRRORFILELIST if (longCommandWArg(&argument, "--output-dir-mirror")) { NEXT_FIELD(outMirroredDirName); continue; } #endif @@ -1220,7 +1216,7 @@ int main(int argCount, const char* argv[]) } } #else - (void)singleThread; (void)nbWorkers; + (void)singleThread; (void)nbWorkers; (void)defaultLogicalCores; #endif g_utilDisplayLevel = g_displayLevel;