lib/zstd
1
0
Fork 0
mirror of https://github.com/facebook/zstd.git synced 2025-07-29 11:21:22 +03:00
Code Activity

fixed zstd-pgo target for GCC

Browse Source 
Since your Makefile uses obj/$(HASH_DIR) for object files, this code does not work correctly for GCC. Because profiles are saved in one directory, and are expected in another when reading.

`$(RM) zstd *.o` - this line doesn't delete object files.

Clang stores profiles in the current directory, so the problem doesn't appear when compiling with Clang.

Also this code will work if BUILD_DIR is set.
This commit is contained in:
Ilya Kurdyukov
2022-10-05 17:32:16 +07:00
committed by GitHub
parent 33273e1b9c
commit 2ffcb2d6a8
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
programs/Makefile
View File

@ -232,17 +232,21 @@ zstd-dll : zstd
## zstd-pgo: zstd executable optimized with PGO. ## zstd-pgo: zstd executable optimized with PGO.
.PHONY: zstd-pgo .PHONY: zstd-pgo
zstd-pgo : zstd-pgo :
$(MAKE) clean $(MAKE) clean HASH_DIR=$(HASH_DIR)
$(MAKE) zstd MOREFLAGS=-fprofile-generate $(MAKE) zstd HASH_DIR=$(HASH_DIR) MOREFLAGS=-fprofile-generate
./zstd -b19i1 $(PROFILE_WITH) ./zstd -b19i1 $(PROFILE_WITH)
./zstd -b16i1 $(PROFILE_WITH) ./zstd -b16i1 $(PROFILE_WITH)
./zstd -b9i2 $(PROFILE_WITH) ./zstd -b9i2 $(PROFILE_WITH)
./zstd -b $(PROFILE_WITH) ./zstd -b $(PROFILE_WITH)
./zstd -b7i2 $(PROFILE_WITH) ./zstd -b7i2 $(PROFILE_WITH)
./zstd -b5 $(PROFILE_WITH) ./zstd -b5 $(PROFILE_WITH)
$(RM) zstd *.o ifndef BUILD_DIR
$(RM) zstd obj/$(HASH_DIR)/*.o
else
$(RM) zstd $(BUILD_DIR)/*.o
endif
case $(CC) in *clang*) if ! [ -e default.profdata ]; then llvm-profdata merge -output=default.profdata default*.profraw; fi ;; esac case $(CC) in *clang*) if ! [ -e default.profdata ]; then llvm-profdata merge -output=default.profdata default*.profraw; fi ;; esac
$(MAKE) zstd MOREFLAGS=-fprofile-use $(MAKE) zstd HASH_DIR=$(HASH_DIR) MOREFLAGS=-fprofile-use
## zstd-small: minimal target, supporting only zstd compression and decompression. no bench. no legacy. no other format. ## zstd-small: minimal target, supporting only zstd compression and decompression. no bench. no legacy. no other format.
CLEAN += zstd-small zstd-frugal CLEAN += zstd-small zstd-frugal