From 2e63a877f35049c48fc142e3bd5b20bfc6558a02 Mon Sep 17 00:00:00 2001 From: Yann Collet Date: Tue, 2 May 2017 15:40:42 -0700 Subject: [PATCH] fixed xzstd --format=xz was missing a break, making the execution continue into lz4 error message --- programs/Makefile | 6 ++---- programs/fileio.c | 4 ++++ programs/zstdcli.c | 4 ++-- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/programs/Makefile b/programs/Makefile index 2ab29e1ef..0c50f50bd 100644 --- a/programs/Makefile +++ b/programs/Makefile @@ -140,15 +140,13 @@ $(ZSTDDECOMP_O): CFLAGS += $(ALIGN_LOOP) zstd : CPPFLAGS += $(ZLIBCPP) $(THREAD_CPP) zstd : LDFLAGS += $(ZLIBLD) $(THREAD_LD) -zstd : LZMA_MSG := $(NO_LZMA_MSG) +zstd zstd-nogz zstd4 : LZMA_MSG := "" +zstd zstd-nogz xzstd : LZ4_MSG := "" zstd-nogz : ZLIB_MSG := $(NO_ZLIB_MSG) -zstd-nogz : LZMA_MSG := $(NO_LZMA_MSG) xzstd : CPPFLAGS += $(ZLIBCPP) $(LZMACPP) xzstd : LDFLAGS += $(ZLIBLD) $(LZMALD) -xzstd : LZ4_MSG := $(NO_LZ4_MSG) zstd4 : CPPFLAGS += $(ZLIBCPP) $(LZ4CPP) zstd4 : LDFLAGS += $(ZLIBLD) $(LZ4LD) -zstd4 : LZMA_MSG := $(NO_LZMA_MSG) zstd zstd-nogz xzstd zstd4 : CPPFLAGS += -DZSTD_LEGACY_SUPPORT=$(ZSTD_LEGACY_SUPPORT) zstd zstd-nogz xzstd zstd4 : $(ZSTDLIB_FILES) zstdcli.o fileio.o bench.o datagen.o dibio.o @echo "$(THREAD_MSG)" diff --git a/programs/fileio.c b/programs/fileio.c index 944b11ab4..e188936b2 100644 --- a/programs/fileio.c +++ b/programs/fileio.c @@ -617,6 +617,7 @@ static int FIO_compressFilename_internal(cRess_t ress, switch (g_compressionType) { case FIO_zstdCompression: break; + case FIO_gzipCompression: #ifdef ZSTD_GZCOMPRESS compressedfilesize = FIO_compressGzFrame(&ress, srcFileName, fileSize, compressionLevel, &readsize); @@ -625,6 +626,7 @@ static int FIO_compressFilename_internal(cRess_t ress, EXM_THROW(20, "zstd: %s: file cannot be compressed as gzip (zstd compiled without ZSTD_GZCOMPRESS) -- ignored \n", srcFileName); #endif goto finish; + case FIO_xzCompression: case FIO_lzmaCompression: #ifdef ZSTD_LZMACOMPRESS @@ -633,6 +635,8 @@ static int FIO_compressFilename_internal(cRess_t ress, (void)compressionLevel; EXM_THROW(20, "zstd: %s: file cannot be compressed as xz/lzma (zstd compiled without ZSTD_LZMACOMPRESS) -- ignored \n", srcFileName); #endif + goto finish; + case FIO_lz4Compression: #ifdef ZSTD_LZ4COMPRESS compressedfilesize = FIO_compressLz4Frame(&ress, srcFileName, fileSize, compressionLevel, &readsize); diff --git a/programs/zstdcli.c b/programs/zstdcli.c index f6ce2e1a6..32fef9993 100644 --- a/programs/zstdcli.c +++ b/programs/zstdcli.c @@ -514,11 +514,11 @@ int main(int argCount, const char* argv[]) /* Quiet mode */ case 'q': g_displayLevel--; argument++; break; - /* keep source file (default); for gzip/xz compatibility */ + /* keep source file (default) */ case 'k': FIO_setRemoveSrcFile(0); argument++; break; /* Checksum */ - case 'C': argument++; FIO_setChecksumFlag(2); break; + case 'C': FIO_setChecksumFlag(2); argument++; break; /* test compressed file */ case 't': operation=zom_test; argument++; break;