lib/zstd
1
0
Fork 0
mirror of https://github.com/facebook/zstd.git synced 2025-08-07 06:23:00 +03:00
Code Activity

added golden file for the new decompressor erratum

Browse Source
This commit is contained in:
Yann Collet
2023-04-19 00:24:35 -07:00
parent a29b6ed251
commit 0d6954b4cc
3 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
doc/decompressor_errata.md
View File

@@ -6,7 +6,7 @@ Each entry will contain:
1. The last affected decompressor versions. 1. The last affected decompressor versions.
2. The decompressor components affected. 2. The decompressor components affected.
2. Whether the compressed frame could ever be produced by the reference compressor. 2. Whether the compressed frame could ever be produced by the reference compressor.
3. An example frame when it can be short enough to be displayed as hexadecimal 3. An example frame (hexadecimal string when it can be short enough, link to golden file otherwise)
4. A description of the bug. 4. A description of the bug.
The document is in reverse chronological order, with the bugs that affect the most recent zstd decompressor versions listed first. The document is in reverse chronological order, with the bugs that affect the most recent zstd decompressor versions listed first.
@@ -21,7 +21,10 @@ Compressed block with a size of exactly 128 KB
**Produced by the reference compressor**: No **Produced by the reference compressor**: No
**Example Frame**: see zstd/tests/golden-decompression/block-128k.zst
The zstd decoder incorrectly rejected blocks of type `Compressed_Block` when their size was exactly 128 KB. The zstd decoder incorrectly rejected blocks of type `Compressed_Block` when their size was exactly 128 KB.
Note that `128 KB - 1` was accepted, and `128 KB + 1` is forbidden by the spec.
This type of block was never generated by the reference compressor. This type of block was never generated by the reference compressor.

2
doc/educational_decoder/zstd_decompress.c
View File

@@ -1399,7 +1399,7 @@ size_t ZSTD_get_decompressed_size(const void *src, const size_t src_len) {
/******* END OUTPUT SIZE COUNTING *********************************************/ /******* END OUTPUT SIZE COUNTING *********************************************/
/******* DICTIONARY PARSING ***************************************************/ /******* DICTIONARY PARSING ***************************************************/
dictionary_t* create_dictionary() { dictionary_t* create_dictionary(void) {
dictionary_t* const dict = calloc(1, sizeof(dictionary_t)); dictionary_t* const dict = calloc(1, sizeof(dictionary_t));
if (!dict) { if (!dict) {
BAD_ALLOC(); BAD_ALLOC();

BIN
tests/golden-decompression/block-128k.zst Normal file
View File

Binary file not shown.