lib/zstd
1
0
Fork 0
mirror of https://github.com/facebook/zstd.git synced 2025-08-05 19:15:58 +03:00
Code Activity

[cmake] use target_compile_definitions

Browse Source 
which is considered best practice.
This commit is contained in:
Yann Collet
2025-02-20 15:21:48 -08:00
parent 1bef87857b
commit 0c3345d6ec
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
build/cmake/lib/CMakeLists.txt
View File

@@ -112,7 +112,7 @@ endif()
macro (add_definition target var) macro (add_definition target var)
if (NOT ("${${var}}" STREQUAL "")) if (NOT ("${${var}}" STREQUAL ""))
set_property(TARGET ${target} APPEND PROPERTY COMPILE_DEFINITIONS "${var}=__attribute__((visibility(\"${${var}}\")))") target_compile_definitions(${target} PUBLIC "${var}=__attribute__((visibility(\"${${var}}\")))")
endif () endif ()
endmacro () endmacro ()
@@ -126,7 +126,7 @@ if (ZSTD_BUILD_SHARED)
target_include_directories(libzstd_shared INTERFACE $<BUILD_INTERFACE:${PUBLIC_INCLUDE_DIRS}>) target_include_directories(libzstd_shared INTERFACE $<BUILD_INTERFACE:${PUBLIC_INCLUDE_DIRS}>)
list(APPEND library_targets libzstd_shared) list(APPEND library_targets libzstd_shared)
if (ZSTD_MULTITHREAD_SUPPORT) if (ZSTD_MULTITHREAD_SUPPORT)
set_property(TARGET libzstd_shared APPEND PROPERTY COMPILE_DEFINITIONS "ZSTD_MULTITHREAD") target_compile_definitions(libzstd_shared PUBLIC ZSTD_MULTITHREAD)
if (UNIX) if (UNIX)
target_link_libraries(libzstd_shared ${THREADS_LIBS}) target_link_libraries(libzstd_shared ${THREADS_LIBS})
endif () endif ()
@@ -140,7 +140,7 @@ if (ZSTD_BUILD_STATIC)
target_include_directories(libzstd_static INTERFACE $<BUILD_INTERFACE:${PUBLIC_INCLUDE_DIRS}>) target_include_directories(libzstd_static INTERFACE $<BUILD_INTERFACE:${PUBLIC_INCLUDE_DIRS}>)
list(APPEND library_targets libzstd_static) list(APPEND library_targets libzstd_static)
if (ZSTD_MULTITHREAD_SUPPORT) if (ZSTD_MULTITHREAD_SUPPORT)
set_property(TARGET libzstd_static APPEND PROPERTY COMPILE_DEFINITIONS "ZSTD_MULTITHREAD") target_compile_definitions(libzstd_static PUBLIC ZSTD_MULTITHREAD)
if (UNIX) if (UNIX)
target_link_libraries(libzstd_static ${THREADS_LIBS}) target_link_libraries(libzstd_static ${THREADS_LIBS})
endif () endif ()
@@ -207,7 +207,7 @@ if (ZSTD_BUILD_SHARED)
OUTPUT_NAME zstd OUTPUT_NAME zstd
VERSION ${ZSTD_FULL_VERSION} VERSION ${ZSTD_FULL_VERSION}
SOVERSION ${zstd_VERSION_MAJOR}) SOVERSION ${zstd_VERSION_MAJOR})
if (ZSTD_FRAMEWORK) if (ZSTD_FRAMEWORK)
set_target_properties( set_target_properties(
libzstd_shared libzstd_shared