lib/wsrep-lib
1
0
Fork 0
mirror of https://github.com/codership/wsrep-lib.git synced 2025-07-31 18:24:25 +03:00
Code Activity

codership/wsrep-lib#90 Fixed assertion in before_commit()

Browse Source 
Added unit test which makes assertion to fail if the fix is not
present.
This commit is contained in:
Teemu Ollakka
2019-02-24 12:05:58 +02:00
parent 9bec7d940c
commit c61811ed70
2 changed files with 23 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/transaction.cpp
View File

@ -373,7 +373,8 @@ int wsrep::transaction::before_commit()
|| ||
(state() == s_must_abort || (state() == s_must_abort ||
state() == s_must_replay || state() == s_must_replay ||
state() == s_cert_failed)); state() == s_cert_failed ||
state() == s_aborted));
} }
else if (state() != s_committing) else if (state() != s_committing)
{ {

21
test/transaction_test.cpp
View File

@ -1056,6 +1056,27 @@ BOOST_FIXTURE_TEST_CASE(
BOOST_REQUIRE(sc.provider().commit_fragments() == 1); BOOST_REQUIRE(sc.provider().commit_fragments() == 1);
} }
//
// Fragments are removed in before_prepare in running transaction context.
// In 1pc the before_prepare() is called from before_commit().
// However, the BF abort may arrive during this removal and the
// client_service::remove_fragments() may roll back the transaction
// internally. This will cause the transaction to leave before_prepare()
// in aborted state.
//
BOOST_FIXTURE_TEST_CASE(transaction_streaming_1pc_bf_abort_during_fragment_removal,
streaming_client_fixture_row)
{
BOOST_REQUIRE(cc.start_transaction(wsrep::transaction_id(1)) == 0);
BOOST_REQUIRE(cc.after_row() == 0);
BOOST_REQUIRE(tc.streaming_context().fragments_certified() == 1);
cc.bf_abort_during_fragment_removal_ = true;
BOOST_REQUIRE(cc.before_commit());
BOOST_REQUIRE(tc.state() == wsrep::transaction::s_aborted);
BOOST_REQUIRE(cc.after_statement());
BOOST_REQUIRE(tc.active() == false);
}
// //
// Test streaming rollback // Test streaming rollback
// //