lib/wsrep-lib
1
0
Fork 0
mirror of https://github.com/codership/wsrep-lib.git synced 2025-07-28 20:02:00 +03:00
Code Activity

Allow concurrent server_state disconnect operations.

Browse Source 
Shutting down the provider may cause replication/appling failures, which
may further result to disconnect calls from failing operations.
Allow concurrent disconnect requests to deal with such a situations.
This commit is contained in:
Teemu Ollakka
2019-12-08 13:42:11 +02:00
parent 29e061116a
commit 90157ed1b0
2 changed files with 43 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/server_state.cpp
View File

@ -524,6 +524,15 @@ int wsrep::server_state::disconnect()
{ {
{ {
wsrep::unique_lock<wsrep::mutex> lock(mutex_); wsrep::unique_lock<wsrep::mutex> lock(mutex_);
// In case of failure situations which are caused by provider
// being shut down some failing operation may also try to shut
// down the replication. Check the state here and
// return success if the provider disconnect is already in progress
// or has completed.
if (state(lock) == s_disconnecting || state(lock) == s_disconnected)
{
return 0;
}
state(lock, s_disconnecting); state(lock, s_disconnecting);
interrupt_state_waiters(lock); interrupt_state_waiters(lock);
} }

34
test/server_context_test.cpp
View File

@ -615,3 +615,37 @@ BOOST_FIXTURE_TEST_CASE(
ss.resume_and_resync(); ss.resume_and_resync();
BOOST_REQUIRE(ss.state() == wsrep::server_state::s_synced); BOOST_REQUIRE(ss.state() == wsrep::server_state::s_synced);
} }
/////////////////////////////////////////////////////////////////////////////
// Disconnect //
/////////////////////////////////////////////////////////////////////////////
BOOST_FIXTURE_TEST_CASE(
server_state_disconnect,
sst_first_server_fixture)
{
bootstrap();
ss.disconnect();
BOOST_REQUIRE(ss.state() == wsrep::server_state::s_disconnecting);
final_view();
BOOST_REQUIRE(ss.state() == wsrep::server_state::s_disconnected);
}
// This test case verifies that the disconnect can be initiated
// concurrently by several callers. This may happen in failure situations
// where provider shutdown causes cascading failures and the failing operations
// try to disconnect the provider.
BOOST_FIXTURE_TEST_CASE(
server_state_disconnect_twice,
sst_first_server_fixture)
{
bootstrap();
ss.disconnect();
BOOST_REQUIRE(ss.state() == wsrep::server_state::s_disconnecting);
ss.disconnect();
BOOST_REQUIRE(ss.state() == wsrep::server_state::s_disconnecting);
final_view();
BOOST_REQUIRE(ss.state() == wsrep::server_state::s_disconnected);
ss.disconnect();
BOOST_REQUIRE(ss.state() == wsrep::server_state::s_disconnected);
}