lib/wsrep-lib
1
0
Fork 0
mirror of https://github.com/codership/wsrep-lib.git synced 2025-07-30 07:23:07 +03:00
Code Activity

Handle BF abort during fragment removal

Browse Source 
Fragment removal for SR transaction is done in transaction context
to make it atomic. However, this means that if the BF abort arrives
during fragment removal, the transaction may be rolled back inside
client_service::remove_fragments(), and client_state::after_prepare()
is left in aborted state. This case was not handled in the
post condition checks of after_prepare().

Fixed assertion in after_prepare() and implemented unit test.
This commit is contained in:
Teemu Ollakka
2019-02-15 11:44:17 +02:00
parent 9c387ef82f
commit 8c2daa7e3d
3 changed files with 37 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
test/transaction_test_2pc.cpp
View File

@ -240,6 +240,26 @@ BOOST_FIXTURE_TEST_CASE(transaction_streaming_2pc_commit_two_statements,
BOOST_REQUIRE(sc.provider().commit_fragments() == 1);
}
//
// Fragments are removed in before_prepare in running transaction context.
// However, the BF abort may arrive during this removal and the
// client_service::remove_fragments() may roll back the transaction
// internally. This will cause the transaction to leave before_prepare()
// in aborted state.
//
BOOST_FIXTURE_TEST_CASE(transaction_streaming_2pc_bf_abort_during_fragment_removal,
streaming_client_fixture_row)
{
BOOST_REQUIRE(cc.start_transaction(wsrep::transaction_id(1)) == 0);
BOOST_REQUIRE(cc.after_row() == 0);
BOOST_REQUIRE(tc.streaming_context().fragments_certified() == 1);
cc.bf_abort_during_fragment_removal_ = true;
BOOST_REQUIRE(cc.before_prepare());
BOOST_REQUIRE(tc.state() == wsrep::transaction::s_aborted);
BOOST_REQUIRE(cc.after_statement());
BOOST_REQUIRE(tc.active() == false);
}
///////////////////////////////////////////////////////////////////////////////
// APPLYING //
///////////////////////////////////////////////////////////////////////////////