From 7dafce8403d4088ddc8748f2e08eae13b1f225b6 Mon Sep 17 00:00:00 2001 From: Teemu Ollakka Date: Fri, 26 May 2023 13:35:31 +0300 Subject: [PATCH] Remove wrong assertion from transaction::cleanup() In case if SR transaction gets BF aborted before it is certified, the replay will happen but if the replay fails due to certification conflict, the transaction is not terminated in provider replay and will keep its streaming status. Removed the wrong assertion about streaming status from transaction::cleanup(). --- src/transaction.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/transaction.cpp b/src/transaction.cpp index 1783bd4..77316fa 100644 --- a/src/transaction.cpp +++ b/src/transaction.cpp @@ -2084,7 +2084,6 @@ int wsrep::transaction::replay(wsrep::unique_lock& lock) void wsrep::transaction::cleanup() { debug_log_state("cleanup_enter"); - assert(is_streaming() == false); assert(state() == s_committed || state() == s_aborted); id_ = wsrep::transaction_id::undefined(); ws_handle_ = wsrep::ws_handle();