lib/wsrep-lib
1
0
Fork 0
mirror of https://github.com/codership/wsrep-lib.git synced 2025-07-27 09:01:50 +03:00
Code Activity

allowing application to set transaction as PA unsafe

Browse Source 
* Removed transaction::p_unsafe_ member
* Changed transaction::pa_unsafe(bool) to modify flags member directly
* Modified transaction.cpp to use transaction.pa_unsafe(bool) rather than
  directly changing transaction's flag
* added method mark_transaction_pa_unsafe() for client_state,
  application will use this
This commit is contained in:
sjaakola
2021-05-14 14:56:02 +03:00
parent f271ad0c6e
commit 608ee82b26
3 changed files with 27 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
include/wsrep/client_state.hpp
View File

@ -927,6 +927,22 @@ namespace wsrep
return transaction_; return transaction_;
} }
/**
* Mark the transaction associated with the client state
* (if any), as unsafe for parallel applying
*
* @return Zero on success, non-zero on error.
*/
int mark_transaction_pa_unsafe()
{
if (transaction_.active())
{
transaction_.pa_unsafe(true);
return 0;
}
return 1;
}
const wsrep::ws_meta& toi_meta() const const wsrep::ws_meta& toi_meta() const
{ {
return toi_meta_; return toi_meta_;

12
include/wsrep/transaction.hpp
View File

@ -143,9 +143,14 @@ namespace wsrep
int xa_replay(wsrep::unique_lock<wsrep::mutex>&); int xa_replay(wsrep::unique_lock<wsrep::mutex>&);
bool pa_unsafe() const { return pa_unsafe_; } bool pa_unsafe() const { return (flags() & wsrep::provider::flag::pa_unsafe); }
void pa_unsafe(bool pa_unsafe) { pa_unsafe_ = pa_unsafe; } void pa_unsafe(bool pa_unsafe) {
if (pa_unsafe) {
flags(flags() | wsrep::provider::flag::pa_unsafe);
} else {
flags(flags() & ~wsrep::provider::flag::pa_unsafe);
}
}
bool implicit_deps() const { return implicit_deps_; } bool implicit_deps() const { return implicit_deps_; }
void implicit_deps(bool implicit) { implicit_deps_ = implicit; } void implicit_deps(bool implicit) { implicit_deps_ = implicit; }
@ -265,7 +270,6 @@ namespace wsrep
wsrep::ws_handle ws_handle_; wsrep::ws_handle ws_handle_;
wsrep::ws_meta ws_meta_; wsrep::ws_meta ws_meta_;
int flags_; int flags_;
bool pa_unsafe_;
bool implicit_deps_; bool implicit_deps_;
bool certified_; bool certified_;
size_t fragments_certified_for_statement_; size_t fragments_certified_for_statement_;

8
src/transaction.cpp
View File

@ -101,7 +101,6 @@ wsrep::transaction::transaction(
, ws_handle_() , ws_handle_()
, ws_meta_() , ws_meta_()
, flags_() , flags_()
, pa_unsafe_(false)
, implicit_deps_(false) , implicit_deps_(false)
, certified_(false) , certified_(false)
, fragments_certified_for_statement_() , fragments_certified_for_statement_()
@ -326,7 +325,7 @@ int wsrep::transaction::before_prepare(
{ {
// Force fragment replication on XA prepare // Force fragment replication on XA prepare
flags(flags() | wsrep::provider::flag::prepare); flags(flags() | wsrep::provider::flag::prepare);
flags(flags() | wsrep::provider::flag::pa_unsafe); pa_unsafe(true);
append_sr_keys_for_commit(); append_sr_keys_for_commit();
const bool force_streaming_step = true; const bool force_streaming_step = true;
ret = streaming_step(lock, force_streaming_step); ret = streaming_step(lock, force_streaming_step);
@ -1116,7 +1115,7 @@ int wsrep::transaction::commit_or_rollback_by_xid(const wsrep::xid& xid,
{ {
flags = wsrep::provider::flag::rollback; flags = wsrep::provider::flag::rollback;
} }
flags = flags | wsrep::provider::flag::pa_unsafe; pa_unsafe(true);
wsrep::stid stid(sa->transaction().server_id(), wsrep::stid stid(sa->transaction().server_id(),
sa->transaction().id(), sa->transaction().id(),
client_state_.id()); client_state_.id());
@ -1650,7 +1649,7 @@ int wsrep::transaction::certify_commit(
{ {
append_sr_keys_for_commit(); append_sr_keys_for_commit();
} }
flags(flags() | wsrep::provider::flag::pa_unsafe); pa_unsafe(true);
} }
if (implicit_deps()) if (implicit_deps())
@ -1956,7 +1955,6 @@ void wsrep::transaction::cleanup()
ws_meta_ = wsrep::ws_meta(); ws_meta_ = wsrep::ws_meta();
flags_ = 0; flags_ = 0;
certified_ = false; certified_ = false;
pa_unsafe_ = false;
implicit_deps_ = false; implicit_deps_ = false;
sr_keys_.clear(); sr_keys_.clear();
streaming_context_.cleanup(); streaming_context_.cleanup();