lib/wsrep-lib
1
0
Fork 0
mirror of https://github.com/codership/wsrep-lib.git synced 2025-07-24 10:42:31 +03:00
Code Activity

Fix assertion unallowed state transition: connected -> joined

Browse Source 
When the donor lost its donor state during SST due to cluster
partitioning, the state was erranously changed to `s_joined`
in `start_sst()` and `sst_sent()`, which caused assertion failures
in state checking.

Fixed by changing state to `s_joined` only if donor is still in
`s_donor` state.
This commit is contained in:
Teemu Ollakka
2023-02-26 11:43:44 +02:00
parent 3b3429d8df
commit 5a943b66a7
3 changed files with 77 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/server_state.cpp
View File

@ -1,5 +1,5 @@
/*
* Copyright (C) 2018-2019 Codership Oy <info@codership.com>
* Copyright (C) 2018-2023 Codership Oy <info@codership.com>
*
* This file is part of wsrep-lib.
*
@ -675,8 +675,12 @@ int wsrep::server_state::start_sst(const std::string& sst_request,
lock.lock();
wsrep::log_warning() << "SST preparation failed";
// v26 API does not have JOINED event, so in anticipation of SYNCED
// we must do it here.
state(lock, s_joined);
// we must do it here. Do not modify the state if donor lost the
// donor state e.g. due to cluster partitioning.
if (state(lock) == s_donor)
{
state(lock, s_joined);
}
ret = 1;
}
return ret;
@ -691,8 +695,13 @@ void wsrep::server_state::sst_sent(const wsrep::gtid& gtid, int error)
wsrep::unique_lock<wsrep::mutex> lock(mutex_);
// v26 API does not have JOINED event, so in anticipation of SYNCED
// we must do it here.
state(lock, s_joined);
// we must do it here. Do not modify the state if donor lost the
// donor state e.g. due to cluster partitioning.
if (state(lock) == s_donor)
{
state(lock, s_joined);
}
lock.unlock();
enum provider::status const retval(provider().sst_sent(gtid, error));
if (retval != provider::success)