lib/wsrep-lib
1
0
Fork 0
mirror of https://github.com/codership/wsrep-lib.git synced 2025-07-28 20:02:00 +03:00
Code Activity

codership/wsrep-lib#35 Rewrote member_index() to use iterators

Browse Source 
Use iterators for scanning members vector in order to avoid
issues with integer signedness and range checks. The vector is
usually rather small and not in hot codepath, so performance
is here not an issue.

Added unit test for member_index() method.
This commit is contained in:
Teemu Ollakka
2018-12-15 13:46:42 +00:00
parent 80dcf4b6d2
commit 36dbb37645
4 changed files with 50 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/view.cpp
View File

@ -22,21 +22,14 @@
int wsrep::view::member_index(const wsrep::id& member_id) const
{
// first, quick guess
if (own_index_ >= 0 && members_[own_index_].id() == member_id)
for (std::vector<member>::const_iterator i(members_.begin());
i != members_.end(); ++i)
{
return own_index_;
}
// guesing didn't work, scan the list
for (size_t i(0); i < members_.size(); ++i)
{
if (static_cast<int>(i) != own_index_ && members_[i].id() == member_id)
if (i->id() == member_id)
{
return i;
return (i - members_.begin());
}
}
return -1;
}