lib/wsrep-lib
1
0
Fork 0
mirror of https://github.com/codership/wsrep-lib.git synced 2025-07-28 20:02:00 +03:00
Code Activity

Relaxed server_state state transition sanity checks

Browse Source 
In release build log a warning but continue with state transition
anyway. In debug build log warning and crash in assert.
This commit is contained in:
Teemu Ollakka
2019-01-21 13:41:32 +02:00
parent 76875c3be1
commit 144d8c13c1
1 changed files with 15 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/server_state.cpp
View File

@ -1093,28 +1093,25 @@ void wsrep::server_state::state(
{ 1, 0, 0, 0, 0, 0, 0, 0, 0} /* ding */ { 1, 0, 0, 0, 0, 0, 0, 0, 0} /* ding */
}; };
if (allowed[state_][state]) if (allowed[state_][state] == false)
{
wsrep::log_debug() << "server " << name_ << " state change: "
<< to_c_string(state_) << " -> "
<< to_c_string(state);
state_hist_.push_back(state_);
server_service_.log_state_change(state_, state);
state_ = state;
cond_.notify_all();
while (state_waiters_[state_])
{
cond_.wait(lock);
}
}
else
{ {
std::ostringstream os; std::ostringstream os;
os << "server: " << name_ << " unallowed state transition: " os << "server: " << name_ << " unallowed state transition: "
<< wsrep::to_string(state_) << " -> " << wsrep::to_string(state); << wsrep::to_string(state_) << " -> " << wsrep::to_string(state);
wsrep::log_error() << os.str() << "\n"; wsrep::log_warning() << os.str() << "\n";
::abort(); assert(0);
// throw wsrep::runtime_error(os.str()); }
wsrep::log_debug() << "server " << name_ << " state change: "
<< to_c_string(state_) << " -> "
<< to_c_string(state);
state_hist_.push_back(state_);
server_service_.log_state_change(state_, state);
state_ = state;
cond_.notify_all();
while (state_waiters_[state_])
{
cond_.wait(lock);
} }
} }