From 0304aa85c78aa9d887d494baf9ccfddeb9cac681 Mon Sep 17 00:00:00 2001
From: Daniele Sciascia <daniele.sciascia@galeracluster.com>
Date: Wed, 9 Jun 2021 17:40:43 +0200
Subject: [PATCH] Fix pa_unsafe flag in
 transaction::commit_or_rollback_by_xid()

Remove `flags` local variable and use flags_ member in
transaction::commit_or_rollback_by_xid(). This avoids a case where the
pa_unsafe flag was not passed to provider.
---
 src/transaction.cpp | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/transaction.cpp b/src/transaction.cpp
index 7be5e35..4ac9ee1 100644
--- a/src/transaction.cpp
+++ b/src/transaction.cpp
@@ -1106,14 +1106,13 @@ int wsrep::transaction::commit_or_rollback_by_xid(const wsrep::xid& xid,
         return 1;
     }
 
-    int flags(0);
     if (commit)
     {
-        flags = wsrep::provider::flag::commit;
+        flags(wsrep::provider::flag::commit);
     }
     else
     {
-        flags = wsrep::provider::flag::rollback;
+        flags(wsrep::provider::flag::rollback);
     }
     pa_unsafe(true);
     wsrep::stid stid(sa->transaction().server_id(),
@@ -1124,7 +1123,7 @@ int wsrep::transaction::commit_or_rollback_by_xid(const wsrep::xid& xid,
     const enum wsrep::provider::status cert_ret(
         provider().certify(client_state_.id(),
                            ws_handle_,
-                           flags,
+                           flags(),
                            meta));
 
     int ret;