Summary: `${service}_processmap_serialization.cpp` was mistakenly added to source files in D80006546 while we do not generate this file. Fix it to unbreak fboss and other users of `add_fbthrift_cpp_library`.
Reviewed By: tanquer
Differential Revision: D80189355
fbshipit-source-id: e24f3d38ca8f1762c2636c6c4e4bc5e80aa0699d
Summary: Update the OSS configs to use `<module>_types_serialization.cpp` introduced in D79106423 and remove the `__FBTHRIFT_SEPARATE_SERIALIZATION` workaround.
Reviewed By: iahs
Differential Revision: D80006546
fbshipit-source-id: cdffcef00baff6bb2109a10f59e4cc34439669c7
Summary: fbthrift has moved compact/binary protocol instantiation outside _types.cpp (to _types_compact.cpp and _types_binary.cpp). We need to add these two files to the build system.
Reviewed By: vitaut
Differential Revision: D74768484
fbshipit-source-id: a45c5893489083f98832ff4eb79aee4f568b2dc2
Summary:
Fix fb303 OSS builds on macOS that failing to find xxhash.h.
Problem was that thrift cpp lib now needs xxhash but it wasn't declared in the cmake rules, which shows up as a problem when system xxhash is not installed.
CustomCompressorRegistry.cpp was also missing from cmake build resulting in link errors once the xxhash.h discovery was fixed.
Reviewed By: markbt
Differential Revision: D72452460
fbshipit-source-id: 6bdb8e0e3961529f04f9d9d29ba0daeff2e7ff2a
Summary:
Pass the include directory to the Thrift compiler to fix using the annotation library.
Fixes the following error when building openr:
```
$ opensource/fbcode_builder/getdeps.py build openr
...
[ERROR:/data/users/viz/scratch/dataZusersZvizZfbsource/fbcode_builder_getdeps/shipit/openr/openr/if/Dual.thrift:17] Could not find include file thrift/annotation/cpp.thrift
```
Reviewed By: avalonalex
Differential Revision: D45530515
fbshipit-source-id: ad5586ebe0711d4574dcb4a5e8d61ea8bb544653
Summary:
`add_fbthrift_cpp_library` should honor `BUILD_SHARED_LIBS`, and call
`add_library` with the right setting (`SHARED` if enabled, `STATIC` otherwise)
Reviewed By: yns88
Differential Revision: D24911124
fbshipit-source-id: 79df7640a758a592a3df3e9e79bb129dd57f2d47
Summary: There are downstream oss builds showing build failure caused by introduction of metadata. We want to make them proceed to build so we won't get errors in CI.
Reviewed By: iahs
Differential Revision: D19900007
fbshipit-source-id: 4201448f7980b53e407fd2bc1c74ed4ffa8e18c1
Summary:
Update the thrift C++ and Python CMake rules to indicate that the output also
depends on the thrift compiler itself.
Previously the C++ rule indicated that the output depended on the thrift
template files, which caught most cases when the thrift compiler was updated,
but wasn't fully correct. The thrift templates were also removed and baked
into the thrift compiler binary in D16356056.
Reviewed By: yfeldblum, chadaustin
Differential Revision: D17401217
fbshipit-source-id: ae5cde7a7e5e07a74406a1b6f4469124187bc12f
Summary: [Thrift] Bake templates into the compiler binary rather than having to package the templates with the compiler.
Reviewed By: stevegury, vitaut
Differential Revision: D16356056
fbshipit-source-id: b971dce7aada8dc2a26587fbf818e661acd0c555
Summary: when trying to build openr with `getDeps.py` constant definitions where not available since they were not part of the generated thrift lib. this fixes it.
Reviewed By: chadaustin
Differential Revision: D16064417
fbshipit-source-id: ee2b3e061caf67235f4a873405cf6cd6fb663ef4
Summary:
Fix a minor bug in the argument parsing for `add_fbthrift_cpp_library()`:
only a single value should be supplied for the `THRIFT_INCLUDE_DIR` argument.
This parameter should not accept a list of arguments.
Reviewed By: strager
Differential Revision: D17125810
fbshipit-source-id: 31f354e4d6299d3626a94f3b4b5ff8c58bb0cf7b
Summary:
Rename the `ThriftCppLibrary.cmake` file to `FBThriftCppLibrary.cmake`, and
also rename `add_thrift_cpp2_library()` to `add_fbthrift_cpp_library()`.
Explicitly calling this `fbthrift` helps clearly distinguish that this is
intended for use with fbthrift (https://github.com/facebook/fbthrift/), as
opposed to Apache thrift.
Reviewed By: wez
Differential Revision: D16738440
fbshipit-source-id: 9b255e06b71c98ad74a34989f564a211958dcdd5
