From f1d35639d6b9f2c18a14b5e219f3d21f15686a1e Mon Sep 17 00:00:00 2001 From: Simon Marlow Date: Sat, 1 Jun 2024 07:29:20 -0700 Subject: [PATCH] --shared-libs should be a common argument Summary: X-link: https://github.com/facebookincubator/zstrong/pull/848 Because it should work with `show-inst-dir`, otherwise we can't calculate the right project hash. Reviewed By: chadaustin Differential Revision: D58011867 fbshipit-source-id: d8960b4a993efbada8e27584e56976279fcd6b43 --- build/fbcode_builder/getdeps.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/build/fbcode_builder/getdeps.py b/build/fbcode_builder/getdeps.py index 890d0e74d..014105f3b 100755 --- a/build/fbcode_builder/getdeps.py +++ b/build/fbcode_builder/getdeps.py @@ -810,12 +810,6 @@ class BuildCmd(ProjectCmdBase): ), action="append", ) - parser.add_argument( - "--shared-libs", - help="Build shared libraries if possible", - action="store_true", - default=False, - ) parser.add_argument( "--free-up-disk", help="Remove unused tools and clean up intermediate files if possible to maximise space for the build", @@ -1326,6 +1320,12 @@ def parse_args(): action="store_false", dest="facebook_internal", ) + add_common_arg( + "--shared-libs", + help="Build shared libraries if possible", + action="store_true", + default=False, + ) add_common_arg( "--allow-system-packages", help="Allow satisfying third party deps from installed system packages",