From db79e34cc7c21ec29efdd9447cd26b8a1d33a7e8 Mon Sep 17 00:00:00 2001 From: Manikandan Somasundaram Date: Fri, 3 Feb 2023 10:43:23 -0800 Subject: [PATCH] Update the built_marker hashing logic only for current project (#3934) Summary: Pull Request resolved: https://github.com/facebookincubator/velox/pull/3934 Reviewed By: shri-khare Differential Revision: D42996394 fbshipit-source-id: e4fe54ba6e7f51b4fc640bf80bbb18b257903b1c --- build/fbcode_builder/getdeps.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/build/fbcode_builder/getdeps.py b/build/fbcode_builder/getdeps.py index 86993e00e..146fdb357 100755 --- a/build/fbcode_builder/getdeps.py +++ b/build/fbcode_builder/getdeps.py @@ -627,8 +627,12 @@ class BuildCmd(ProjectCmdBase): ) builder.build(install_dirs, reconfigure=reconfigure) - # Update built_marker only if user hasn't built a specific target - if m == manifest and args.cmake_target == "install": + # If we are building the project (not depdendency) and a specific + # cmake_target (not 'install') has been requested, then we don't + # set the built_marker. This allows subsequent runs of getdeps.py + # for the project to run with different cmake_targets to trigger + # cmake + if not (m == manifest and args.cmake_target != "install"): with open(built_marker, "w") as f: f.write(project_hash)