From cb297102220b1d41930182241deaae6130f3527a Mon Sep 17 00:00:00 2001 From: Chad Austin Date: Tue, 26 Jul 2022 16:43:01 -0700 Subject: [PATCH] if the record_results endpoint fails, don't fail the job Summary: A request to record_results failed, which caused a folly gcc 8 build regression to slip in, which broke the Watchman and EdenFS builds. Instead, turn record_results requests into a logged warning. Reviewed By: xavierd Differential Revision: D38170729 fbshipit-source-id: d59ae5fa48b5cbcf649281108d958ff95e319e35 --- build/fbcode_builder/getdeps/builder.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/build/fbcode_builder/getdeps/builder.py b/build/fbcode_builder/getdeps/builder.py index 3db3adf30..bea1adbce 100644 --- a/build/fbcode_builder/getdeps/builder.py +++ b/build/fbcode_builder/getdeps/builder.py @@ -850,7 +850,8 @@ if __name__ == "__main__": testpilot_args.append("--env") testpilot_args.extend(f"{key}={val}" for key, val in env.items()) - testpilot_args += ["--run-id", str(run_id)] + if run_id is not None: + testpilot_args += ["--run-id", run_id] if test_filter: testpilot_args += ["--", test_filter]