lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2025-08-07 07:02:53 +03:00
Code Activity

Forward fix github build break due to D54280190

Browse Source 
Summary:
X-link: https://github.com/facebookincubator/zstrong/pull/720

When running getdeps as part of Github CI, the toolchains employed are found in "C:\Program Files" or "C:\Program Files(x86)" - both requiring quoting to execute.

Lets add quotes and fix tha.

Reviewed By: vitaut

Differential Revision: D54433098

fbshipit-source-id: d3570486a2a2b12f4649becc987f9da1ca65c796
This commit is contained in:
John Elliott
2024-03-01 15:34:10 -08:00
committed by Facebook GitHub Bot
parent 91747e0083
commit bcbd281941
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
build/fbcode_builder/getdeps/builder.py
View File

@@ -70,7 +70,7 @@ class BuilderBase(object):
wrapper = os.path.join(self.build_dir, "succeed.bat") wrapper = os.path.join(self.build_dir, "succeed.bat")
with open(wrapper, "w") as f: with open(wrapper, "w") as f:
f.write("@echo off\n") f.write("@echo off\n")
f.write(f"call {vcvarsall} amd64\n") f.write(f'call "{vcvarsall}" amd64\n')
f.write("set ERRORLEVEL=0\n") f.write("set ERRORLEVEL=0\n")
f.write("exit /b 0\n") f.write("exit /b 0\n")
return [wrapper, "&&"] return [wrapper, "&&"]