lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2025-08-05 19:55:47 +03:00
Code Activity

Fix getdeps test classification

Browse Source 
Summary:
If getdeps tests run from fbcode, tpx guesses that the test type is FBCODE rather than FBTEST. This makes UTF ignore the buildsystem=getdeps config, which leads tests to be ignored.

This diff sets the test type explicitly.

More context in [this post](https://fb.workplace.com/groups/tpx.users/permalink/1309289352870499/).

Reviewed By: sandeepkumarpani888

Differential Revision: D34271402

fbshipit-source-id: 2c6c37d706f22d214cd2f7622a7124b4c3f92ba0
This commit is contained in:
Andrea Aquino
2022-02-17 11:13:23 -08:00
committed by Facebook GitHub Bot
parent cb560e0fed
commit b93c75d3a5
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
build/fbcode_builder/getdeps/builder.py
View File

@@ -790,6 +790,7 @@ if __name__ == "__main__":
working_dir = get_property(test, "WORKING_DIRECTORY") working_dir = get_property(test, "WORKING_DIRECTORY")
labels = [] labels = []
machine_suffix = self.build_opts.host_type.as_tuple_string() machine_suffix = self.build_opts.host_type.as_tuple_string()
labels.append("tpx-fb-test-type=3")
labels.append("tpx_test_config::buildsystem=getdeps") labels.append("tpx_test_config::buildsystem=getdeps")
labels.append("tpx_test_config::platform={}".format(machine_suffix)) labels.append("tpx_test_config::platform={}".format(machine_suffix))