lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2025-08-10 05:22:59 +03:00
Code Activity

win: add --return-nonzero-on-failures to sc_testpilot

Browse Source 
Summary:
For whatever reason, sc_testpilot default to --return-zero-on-failures, which
means that test failures are simply not reported properly to the signal box.
Fix that by explicitely passing --return-nonzero-on-failures

Reviewed By: fanzeyi

Differential Revision: D29509158

fbshipit-source-id: ef991f91df48e99769f96ffd8d7015cdf507c723
This commit is contained in:
Xavier Deguillard
2021-07-01 09:12:13 -07:00
committed by Facebook GitHub Bot
parent 78cbfd8e6a
commit b810d2701c
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
build/fbcode_builder/getdeps/builder.py
View File

@@ -741,6 +741,7 @@ if __name__ == "__main__":
"--test-config", "--test-config",
"platform=%s" % machine_suffix, "platform=%s" % machine_suffix,
"buildsystem=getdeps", "buildsystem=getdeps",
"--return-nonzero-on-failures",
] ]
else: else:
testpilot_args = [ testpilot_args = [