From af05df1f5d7b5fe33efb5bf89364f29b7543c41c Mon Sep 17 00:00:00 2001 From: Xavier Deguillard Date: Mon, 19 Apr 2021 15:07:16 -0700 Subject: [PATCH] cmake: set CMAKE_CXX_FLAGS in FBCompilerSettingsUnix.cmake Summary: It looks like the various CMAKE_CXX_FLAGS_* are simply ineffective, and I'm not sure why, setting CMAKE_CXX_FLAGS does work though, and CMake appears to add some release/debug flags to it when generating Ninja files. Reviewed By: fanzeyi Differential Revision: D27862117 fbshipit-source-id: a89f6182b5bae9a087f8fcfd4c5f9526f91e2adf --- build/fbcode_builder/CMake/FBCompilerSettingsUnix.cmake | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/build/fbcode_builder/CMake/FBCompilerSettingsUnix.cmake b/build/fbcode_builder/CMake/FBCompilerSettingsUnix.cmake index c095ec840..c26ce78b1 100644 --- a/build/fbcode_builder/CMake/FBCompilerSettingsUnix.cmake +++ b/build/fbcode_builder/CMake/FBCompilerSettingsUnix.cmake @@ -6,6 +6,4 @@ # to these shared compiler settings in order to avoid accidentally # breaking a build in another project! -set(CMAKE_CXX_FLAGS_COMMON "-g -Wall -Wextra -Wno-deprecated -Wno-deprecated-declarations") -set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} ${CMAKE_CXX_FLAGS_COMMON}") -set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} ${CMAKE_CXX_FLAGS_COMMON} -O3") +set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -Wall -Wextra -Wno-deprecated -Wno-deprecated-declarations")