lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2025-08-07 07:02:53 +03:00
Code Activity

getdeps: fix artifact generation (#808)

Browse Source 
Summary:
The mismatched project output settings were causing
the dyndeps fixup to fail to find any objects and thus none of
the artifacts are populated for posix platforms.

Pull Request resolved: https://github.com/facebook/watchman/pull/808

Test Plan:
The PR published artifacts to:

* https://github.com/facebook/watchman/actions/runs/91617994
* https://github.com/facebook/watchman/actions/runs/91617996
* https://github.com/facebook/watchman/actions/runs/91617997

Reviewed By: simpkins

Differential Revision: D21315090

Pulled By: wez

fbshipit-source-id: 60461809f55e73119f7206e3f392d5b237722f85
This commit is contained in:
Wez Furlong
2020-04-29 18:43:06 -07:00
committed by Facebook GitHub Bot
parent b31707b3dd
commit ac0bfe3c4f
3 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/getdeps_linux.yml vendored
View File

@@ -100,7 +100,7 @@ jobs:
- name: Build proxygen - name: Build proxygen
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. proxygen --project-install-prefix proxygen:/usr/local run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. proxygen --project-install-prefix proxygen:/usr/local
- name: Copy artifacts - name: Copy artifacts
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fixup-dyn-deps --src-dir=. proxygen _artifacts/linux --final-install-prefix /usr/local run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fixup-dyn-deps --src-dir=. proxygen _artifacts/linux --project-install-prefix proxygen:/usr/local --final-install-prefix /usr/local
- uses: actions/upload-artifact@master - uses: actions/upload-artifact@master
with: with:
name: proxygen name: proxygen

2
.github/workflows/getdeps_mac.yml vendored
View File

@@ -104,7 +104,7 @@ jobs:
- name: Build proxygen - name: Build proxygen
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. proxygen --project-install-prefix proxygen:/usr/local run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. proxygen --project-install-prefix proxygen:/usr/local
- name: Copy artifacts - name: Copy artifacts
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fixup-dyn-deps --src-dir=. proxygen _artifacts/mac --final-install-prefix /usr/local run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fixup-dyn-deps --src-dir=. proxygen _artifacts/mac --project-install-prefix proxygen:/usr/local --final-install-prefix /usr/local
- uses: actions/upload-artifact@master - uses: actions/upload-artifact@master
with: with:
name: proxygen name: proxygen

3
build/fbcode_builder/getdeps.py
View File

@@ -759,7 +759,8 @@ jobs:
out.write(" - name: Copy artifacts\n") out.write(" - name: Copy artifacts\n")
out.write( out.write(
f" run: {getdeps} fixup-dyn-deps " f" run: {getdeps} fixup-dyn-deps "
f"--src-dir=. {manifest.name} _artifacts/{job_name} --final-install-prefix /usr/local\n" f"--src-dir=. {manifest.name} _artifacts/{job_name} {project_prefix} "
f"--final-install-prefix /usr/local\n"
) )
out.write(" - uses: actions/upload-artifact@master\n") out.write(" - uses: actions/upload-artifact@master\n")