lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2025-08-05 19:55:47 +03:00
Code Activity

avoid using relative path in fb_py_win_main

Browse Source 
Summary:
After some experimenting, it is a little awkward if we want to specify a relative path based on the executable location. We'd need to add a bunch of path calculations to make it right, and I don't think the added complexity is really worth the effort.

As a result, let's just remove the use of relative path, and if we ever want to ship a copy of Python distribution, we can place it under the same directory as the binary.

Reviewed By: chadaustin

Differential Revision: D22394180

fbshipit-source-id: 86d27f6d16a03fe08826b5e5eafcef2a1c77997f
This commit is contained in:
Zeyi (Rice) Fan
2020-07-06 15:25:58 -07:00
committed by Facebook GitHub Bot
parent 98a6467f15
commit a72a5032ce
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
build/fbcode_builder/CMake/fb_py_win_main.c
View File

@@ -6,7 +6,7 @@
#include <stdlib.h>
#include <stdio.h>
#define PATH_SIZE 1024
#define PATH_SIZE 32768
typedef int (*Py_Main)(int, wchar_t**);
@@ -46,7 +46,7 @@ int locate_py_main(int argc, wchar_t **argv) {
// last added directory has highest priority
add_search_path(L"C:\\Python36\\");
add_search_path(L"C:\\Python37\\");
add_search_path(L"..\\python\\");
add_search_path(L"C:\\Python38\\");
python_dll = LoadLibraryExW(L"python3.dll", NULL, LOAD_LIBRARY_SEARCH_DEFAULT_DIRS);