lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2025-08-08 18:02:05 +03:00
Code Activity

cmake: kill testpilot on Windows

Browse Source 
Summary:
TPX is now available on Windows, the testpilot code is thus no longer
necessary.

Reviewed By: fanzeyi

Differential Revision: D37476157

fbshipit-source-id: 885881de2e06eab4990c6c96dcef8f51614a17f5
This commit is contained in:
Xavier Deguillard
2022-07-07 16:39:17 -07:00
committed by Facebook GitHub Bot
parent a33bb50039
commit 8924351a1c
1 changed files with 12 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
build/fbcode_builder/getdeps/builder.py
View File

@@ -816,10 +816,8 @@ if __name__ == "__main__":
# better signals for flaky tests. # better signals for flaky tests.
retry = 0 retry = 0
testpilot = path_search(env, "testpilot") tpx = path_search(env, "tpx")
# TODO(xavierd): once tpx is really available on Windows, remove this. if tpx and not no_testpilot:
tpx = path_search(env, "tpx") if sys.platform != "win32" else None
if (tpx or testpilot) and not no_testpilot:
buck_test_info = list_tests() buck_test_info = list_tests()
import os import os
@@ -835,41 +833,20 @@ if __name__ == "__main__":
from sys import platform from sys import platform
with start_run(env["FBSOURCE_HASH"]) as run_id: with start_run(env["FBSOURCE_HASH"]) as run_id:
if platform == "win32": testpilot_args = [
machine_suffix = self.build_opts.host_type.as_tuple_string() tpx,
testpilot_args = [ "--force-local-execution",
"parexec-testinfra.exe", "--buck-test-info",
"C:/tools/testpilot/sc_testpilot.par", buck_test_info_name,
# Need to force the repo type otherwise testpilot on windows "--retry=%d" % retry,
# can be confused (presumably sparse profile related) "-j=%s" % str(self.num_jobs),
"--force-repo", "--print-long-results",
"fbcode", ]
"--force-repo-root",
self.build_opts.fbsource_dir,
"--buck-test-info",
buck_test_info_name,
"--retry=%d" % retry,
"-j=%s" % str(self.num_jobs),
"--test-config",
"platform=%s" % machine_suffix,
"buildsystem=getdeps",
"--return-nonzero-on-failures",
]
else:
testpilot_args = [
tpx,
"--force-local-execution",
"--buck-test-info",
buck_test_info_name,
"--retry=%d" % retry,
"-j=%s" % str(self.num_jobs),
"--print-long-results",
]
if owner: if owner:
testpilot_args += ["--contacts", owner] testpilot_args += ["--contacts", owner]
if tpx and env: if env:
testpilot_args.append("--env") testpilot_args.append("--env")
testpilot_args.extend(f"{key}={val}" for key, val in env.items()) testpilot_args.extend(f"{key}={val}" for key, val in env.items())