lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2025-08-08 18:02:05 +03:00
Code Activity

--extra-cmake-defines should be a global flag

Browse Source 
Summary:
X-link: https://github.com/facebookincubator/zstrong/pull/858

Because it needs to be passed to other commands that use project
hashes, such as "test".

(in general there are probably a lot more of these, just fixing the
ones I've ran into so far)

Reviewed By: genevievehelsel

Differential Revision: D58082245

fbshipit-source-id: 09fa6b5ce4cc4b3ae7ecfb34ac83681cecb36e3c
This commit is contained in:
Simon Marlow
2024-06-04 11:00:48 -07:00
committed by Facebook GitHub Bot
parent 7bbc009b61
commit 7a68727398
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
build/fbcode_builder/getdeps.py
View File

@@ -788,14 +788,6 @@ class BuildCmd(ProjectCmdBase):
parser.add_argument( parser.add_argument(
"--schedule-type", help="Indicates how the build was activated" "--schedule-type", help="Indicates how the build was activated"
) )
parser.add_argument(
"--extra-cmake-defines",
help=(
"Input json map that contains extra cmake defines to be used "
"when compiling the current project and all its deps. "
'e.g: \'{"CMAKE_CXX_FLAGS": "--bla"}\''
),
)
parser.add_argument( parser.add_argument(
"--cmake-target", "--cmake-target",
help=("Target for cmake build."), help=("Target for cmake build."),
@@ -1326,6 +1318,14 @@ def parse_args():
action="store_true", action="store_true",
default=False, default=False,
) )
add_common_arg(
"--extra-cmake-defines",
help=(
"Input json map that contains extra cmake defines to be used "
"when compiling the current project and all its deps. "
'e.g: \'{"CMAKE_CXX_FLAGS": "--bla"}\''
),
)
add_common_arg( add_common_arg(
"--allow-system-packages", "--allow-system-packages",
help="Allow satisfying third party deps from installed system packages", help="Allow satisfying third party deps from installed system packages",