From 790dd05a052d0295da0f384db7f7fd5d738310e4 Mon Sep 17 00:00:00 2001 From: Hani Damlaj Date: Sun, 18 Oct 2026 10:36:38 -0700 Subject: [PATCH] remove `HQUpstreamSession` ingress push lookups Summary: removes `HQUpstreamSession::findIngressPushStream` and `findIngressPushStreamByPushId`, continued efforts to remove all things http push related in proxygen/lib Reviewed By: Carl-Elkhoury, jbeshay Differential Revision: D124407785 fbshipit-source-id: 31f78a971edb8784ff27f1e1bf738c900af33a30 --- .../lib/http/session/HQUpstreamSession.cpp | 21 ------------------- proxygen/lib/http/session/HQUpstreamSession.h | 4 ---- 2 files changed, 25 deletions(-) diff --git a/proxygen/lib/http/session/HQUpstreamSession.cpp b/proxygen/lib/http/session/HQUpstreamSession.cpp index 15a95acab..6d73ea68e 100644 --- a/proxygen/lib/http/session/HQUpstreamSession.cpp +++ b/proxygen/lib/http/session/HQUpstreamSession.cpp @@ -164,27 +164,6 @@ void HQUpstreamSession::detachThreadLocals(bool) { } } -HQUpstreamSession::HQIngressPushStream* FOLLY_NULLABLE -HQUpstreamSession::findIngressPushStream(quic::StreamId streamId) { - auto res = streamIdToPushId_.find(streamId); - if (res == streamIdToPushId_.end()) { - return nullptr; - } else { - return findIngressPushStreamByPushId(res->second); - } -} - -HQUpstreamSession::HQIngressPushStream* FOLLY_NULLABLE -HQUpstreamSession::findIngressPushStreamByPushId(hq::PushId pushId) { - VLOG(4) << __func__ << " looking up ingress push stream by pushID=" << pushId; - auto it = ingressPushStreams_.find(pushId); - if (it == ingressPushStreams_.end()) { - return nullptr; - } else { - return &it->second; - } -} - uint32_t HQUpstreamSession::numberOfIngressPushStreams() const { return ingressPushStreams_.size(); } diff --git a/proxygen/lib/http/session/HQUpstreamSession.h b/proxygen/lib/http/session/HQUpstreamSession.h index 4c7ce0e62..43eff5f5d 100644 --- a/proxygen/lib/http/session/HQUpstreamSession.h +++ b/proxygen/lib/http/session/HQUpstreamSession.h @@ -197,10 +197,6 @@ class HQUpstreamSession : public HQSession { #pragma warning(pop) #endif - // Find an ingress push stream - HQIngressPushStream* findIngressPushStream(quic::StreamId); - HQIngressPushStream* findIngressPushStreamByPushId(hq::PushId); - uint32_t numberOfIngressPushStreams() const; void dispatchPushStream(quic::StreamId /* pushStreamId */,