diff --git a/build/fbcode_builder/getdeps/builder.py b/build/fbcode_builder/getdeps/builder.py index 17061953a..de562c4a7 100644 --- a/build/fbcode_builder/getdeps/builder.py +++ b/build/fbcode_builder/getdeps/builder.py @@ -64,7 +64,7 @@ class BuilderBase(object): env=None, use_cmd_prefix: bool = True, allow_fail: bool = False, - ): + ) -> int: if env: e = self.env.copy() e.update(env) @@ -86,19 +86,19 @@ class BuilderBase(object): allow_fail=allow_fail, ) - def _reconfigure(self, reconfigure) -> bool: + def _reconfigure(self, reconfigure: bool) -> bool: if self.build_dir is not None: if not os.path.isdir(self.build_dir): os.makedirs(self.build_dir) reconfigure = True return reconfigure - def prepare(self, install_dirs, reconfigure) -> None: + def prepare(self, install_dirs, reconfigure: bool) -> None: print("Preparing %s..." % self.manifest.name) reconfigure = self._reconfigure(reconfigure) self._prepare(install_dirs=install_dirs, reconfigure=reconfigure) - def build(self, install_dirs, reconfigure) -> None: + def build(self, install_dirs, reconfigure: bool) -> None: print("Building %s..." % self.manifest.name) reconfigure = self._reconfigure(reconfigure) self._prepare(install_dirs=install_dirs, reconfigure=reconfigure) diff --git a/build/fbcode_builder/getdeps/envfuncs.py b/build/fbcode_builder/getdeps/envfuncs.py index a9010db32..8ada5d24e 100644 --- a/build/fbcode_builder/getdeps/envfuncs.py +++ b/build/fbcode_builder/getdeps/envfuncs.py @@ -158,7 +158,7 @@ def tpx_path() -> str: return "xplat/testinfra/tpx/ctp.tpx" -def path_search(env, exename, defval=None): +def path_search(env, exename: str, defval=None): """Search for exename in the PATH specified in env. exename is eg: `ninja` and this function knows to append a .exe to the end on windows.