lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2025-08-07 07:02:53 +03:00
Code Activity

fix(fbcode_builder): fail the build when cmake build fails

Browse Source 
Summary:
This change causes fbcode_builder (getdeps.py) to fail immediately on most non-zero error codes from delegated commands.

While internal tools may be able to surface failures in a build that doesn't fail fast, the debug cycle is difficult externally -- this makes failures pop out more easily and has been instrumental in debugging OSS build issues.

X-link: https://github.com/facebook/sapling/pull/1099

Differential Revision: D77608371

Pulled By: quark-zju

fbshipit-source-id: e9fc00a574bc64fbc165a22e51406e85d015e2ae
This commit is contained in:
ben--
2025-07-03 14:28:13 -07:00
committed by Facebook GitHub Bot
parent 4f0db407cf
commit 603a3a6686
4 changed files with 51 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
build/fbcode_builder/getdeps.py
View File

@@ -28,7 +28,7 @@ from getdeps.fetcher import (
from getdeps.load import ManifestLoader
from getdeps.manifest import ManifestParser
from getdeps.platform import HostType
from getdeps.runcmd import run_cmd
from getdeps.runcmd import check_cmd
from getdeps.subcmd import add_subcommands, cmd, SubCmd
try:
@@ -472,7 +472,7 @@ class InstallSysDepsCmd(ProjectCmdBase):
if args.dry_run:
print(" ".join(cmd_args))
else:
run_cmd(cmd_args)
check_cmd(cmd_args)
else:
print("no packages to install")