lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2025-08-07 07:02:53 +03:00
Code Activity

fix tpx command line when filtering is enabled

Browse Source 
Summary:
The testpilot command line getdeps generated was not suitable for tpx
when filtering. tpx would consider the passed test filter an
environment variable.

Reorder a few things to at least make filtering work.

Reviewed By: fanzeyi

Differential Revision: D28976061

fbshipit-source-id: 21c45b3a4a59711a2a5da36a1bd11b7b4871ec5d
This commit is contained in:
Chad Austin
2021-06-09 09:22:24 -07:00
committed by Facebook GitHub Bot
parent 84ef45cb84
commit 5b5ae812bc
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
build/fbcode_builder/getdeps/builder.py
View File

@@ -752,12 +752,15 @@ if __name__ == "__main__":
"--print-long-results", "--print-long-results",
] ]
if owner:
testpilot_args += ["--contacts", owner]
if tpx and env: if tpx and env:
testpilot_args.append("--env") testpilot_args.append("--env")
testpilot_args.extend(f"{key}={val}" for key, val in env.items()) testpilot_args.extend(f"{key}={val}" for key, val in env.items())
if owner: if test_filter:
testpilot_args += ["--contacts", owner] testpilot_args += ["--", test_filter]
if schedule_type == "continuous": if schedule_type == "continuous":
runs.append( runs.append(
@@ -797,9 +800,6 @@ if __name__ == "__main__":
else: else:
runs.append(["--collection", "oss-diff", "--purpose", "diff"]) runs.append(["--collection", "oss-diff", "--purpose", "diff"])
if test_filter:
testpilot_args += [test_filter]
for run in runs: for run in runs:
self._run_cmd( self._run_cmd(
testpilot_args + run, testpilot_args + run,