lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2025-08-08 18:02:05 +03:00
Code Activity

kill openNSA builder

Browse Source 
Summary:
X-link: https://github.com/facebook/fb303/pull/38

As titled, kill open NSA buidler from sandcastle getdeps

Reviewed By: shri-khare

Differential Revision: D47541677

fbshipit-source-id: 4621150a8accd04a9c8bef77b3d0cdaf9b5c3d0a
This commit is contained in:
Srikrishna Gopu
2023-07-28 10:40:59 -07:00
committed by Facebook GitHub Bot
parent 9f92227293
commit 58682505ca
2 changed files with 0 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
build/fbcode_builder/getdeps/builder.py
View File

@@ -1125,26 +1125,6 @@ class NopBuilder(BuilderBase):
shutil.copytree(self.src_dir, self.inst_dir) shutil.copytree(self.src_dir, self.inst_dir)
class OpenNSABuilder(NopBuilder):
# OpenNSA libraries are stored with git LFS. As a result, fetcher fetches
# LFS pointers and not the contents. Use git-lfs to pull the real contents
# before copying to install dir using NoopBuilder.
# In future, if more builders require git-lfs, we would consider installing
# git-lfs as part of the sandcastle infra as against repeating similar
# logic for each builder that requires git-lfs.
def __init__(self, build_opts, ctx, manifest, src_dir, inst_dir) -> None:
super(OpenNSABuilder, self).__init__(
build_opts, ctx, manifest, src_dir, inst_dir
)
def build(self, install_dirs, reconfigure: bool) -> None:
env = self._compute_env(install_dirs)
self._run_cmd(["git", "lfs", "install", "--local"], cwd=self.src_dir, env=env)
self._run_cmd(["git", "lfs", "pull"], cwd=self.src_dir, env=env)
super(OpenNSABuilder, self).build(install_dirs, reconfigure)
class SqliteBuilder(BuilderBase): class SqliteBuilder(BuilderBase):
def __init__(self, build_opts, ctx, manifest, src_dir, build_dir, inst_dir) -> None: def __init__(self, build_opts, ctx, manifest, src_dir, build_dir, inst_dir) -> None:
super(SqliteBuilder, self).__init__( super(SqliteBuilder, self).__init__(

4
build/fbcode_builder/getdeps/manifest.py
View File

@@ -17,7 +17,6 @@ from .builder import (
MakeBuilder, MakeBuilder,
NinjaBootstrap, NinjaBootstrap,
NopBuilder, NopBuilder,
OpenNSABuilder,
OpenSSLBuilder, OpenSSLBuilder,
SqliteBuilder, SqliteBuilder,
) )
@@ -581,9 +580,6 @@ class ManifestParser(object):
build_options, ctx, src_dir, build_dir, inst_dir, loader build_options, ctx, src_dir, build_dir, inst_dir, loader
) )
if builder == "OpenNSA":
return OpenNSABuilder(build_options, ctx, self, src_dir, inst_dir)
raise KeyError("project %s has no known builder" % (self.name)) raise KeyError("project %s has no known builder" % (self.name))
def create_prepare_builders( def create_prepare_builders(