From 5791d5aa9cae3c3b418ab2ae3b83840700fa46d6 Mon Sep 17 00:00:00 2001 From: Wez Furlong Date: Wed, 29 Apr 2020 13:08:33 -0700 Subject: [PATCH] GH actions: fixup boost windows environment (#1359) Summary: The environment changed since I tested D20740410 and now it appears that we'll need to re-export a versioned variable in order for cmake to detect boost on the GH actions hosts. Pull Request resolved: https://github.com/facebook/folly/pull/1359 Test Plan: the GH actions status of this diff. The workflow was updated via: ``` python3 build/fbcode_builder/getdeps.py generate-github-actions folly --output-file .github/workflows/main.yml ``` Reviewed By: yfeldblum Differential Revision: D21307640 Pulled By: yfeldblum fbshipit-source-id: 1555cbcade822775379cd9054be37fdbc17b4d93 --- build/fbcode_builder/getdeps.py | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/build/fbcode_builder/getdeps.py b/build/fbcode_builder/getdeps.py index ae8ccc00b..ce06b5660 100755 --- a/build/fbcode_builder/getdeps.py +++ b/build/fbcode_builder/getdeps.py @@ -705,6 +705,20 @@ jobs: out.write(" - uses: actions/checkout@v1\n") if build_opts.is_windows(): + # cmake relies on BOOST_ROOT but GH deliberately don't set it in order + # to avoid versioning issues: + # https://github.com/actions/virtual-environments/issues/319 + # Instead, set the version we think we need; this is effectively + # coupled with the boost manifest + # This is the unusual syntax for setting an env var for the rest of + # the steps in a workflow: + # https://help.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable + out.write(" - name: Export boost environment\n") + out.write( + ' run: "echo ::set-env name=BOOST_ROOT::%BOOST_ROOT_1_69_0%"\n' + ) + out.write(" shell: cmd\n") + # The git installation may not like long filenames, so tell it # that we want it to use them! out.write(" - name: Fix Git config\n")