lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2025-08-07 07:02:53 +03:00
Code Activity

Only upload cached projects with built_marker (#4087)

Browse Source 
Summary:
X-link: https://github.com/facebookincubator/velox/pull/4087

Under some circumstances, getdeps can cache a project artifact
where there is no built_marker, forcing the script to re-build the artifact
from source.  After D43260530 (47dde7c249) this no longer causes a build failure, but it can
still make builds take longer than they should.

This ensures we only cache artifacts with a built_marker, so that they aren't
overwritten by artifacts without.

Reviewed By: genevievehelsel

Differential Revision: D43405855

fbshipit-source-id: b1b9e194e642fa820d0fbc54a7c15ff81fc90a82
This commit is contained in:
Mark Shroyer
2023-02-22 18:50:08 -08:00
committed by Facebook GitHub Bot
parent 9bcc1277d4
commit 3573a0587c
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
build/fbcode_builder/getdeps.py
View File

@@ -631,12 +631,15 @@ class BuildCmd(ProjectCmdBase):
# set the built_marker. This allows subsequent runs of getdeps.py
# for the project to run with different cmake_targets to trigger
# cmake
has_built_marker = False
if not (m == manifest and args.cmake_target != "install"):
with open(built_marker, "w") as f:
f.write(project_hash)
has_built_marker = True
# Only populate the cache from continuous build runs
if args.schedule_type == "continuous":
# Only populate the cache from continuous build runs, and
# only if we have a built_marker.
if args.schedule_type == "continuous" and has_built_marker:
cached_project.upload()
elif args.verbose:
print("found good %s" % built_marker)