lib/proxygen
1
0
Fork 0
mirror of https://github.com/facebook/proxygen.git synced 2025-04-19 01:04:16 +03:00
Code

Fix CQS signal. Id] 1540596 -- readability-redundant-string-init in fbcode/proxygen/lib/http

Browse Source 
Reviewed By: dtolnay

Differential Revision: D73097505

fbshipit-source-id: 43f1a9cdcf24c7ef3e660bc6737818eba0747944
This commit is contained in:
generatedunixname89002005287564 2025-04-16 20:27:01 -07:00 committed by Facebook GitHub Bot
parent f7d2f6490c
commit 30f9dda460
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
proxygen/lib/http/HTTPHeaders.h
View File

@ -529,7 +529,7 @@ bool HTTPHeaders::forEachValueOfHeader(HTTPHeaderCode code, LAMBDA func) const {
template <typename T>
std::string HTTPHeaders::combine(const T& header,
const std::string& separator) const {
std::string combined = "";
std::string combined;
forEachValueOfHeader(header, [&](const std::string& value) -> bool {
if (combined.empty()) {
combined.append(value);

2
proxygen/lib/http/test/RFC2616Test.cpp
View File

@ -42,7 +42,7 @@ TEST(QvalueTest, Basic) {
}
{
string test("");
string test;
// The spec says a blank one is ok but empty headers are disallowed in SPDY?
EXPECT_FALSE(RFC2616::parseQvalues(test, output));
EXPECT_EQ(output.size(), 0);