From 2015cbb29d51dac49cc8db30ef2784f22a394df2 Mon Sep 17 00:00:00 2001 From: "Zeyi (Rice) Fan" Date: Wed, 9 Dec 2020 17:45:55 -0800 Subject: [PATCH] GitHub Action: fix Windows build Summary: Watchman's GitHub Action has been failing because of the use of `set-env` is deprecated due to security issues. See https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ for details. See https://github.com/facebook/watchman/runs/1520165260?check_suite_focus=true for example of failures. To fix it we just need to write to the special environment file. Reviewed By: chadaustin Differential Revision: D25412442 fbshipit-source-id: d31ef025189c8aebfa08d434d9373f5da7d4690e --- build/fbcode_builder/getdeps.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build/fbcode_builder/getdeps.py b/build/fbcode_builder/getdeps.py index 5c520bba2..56019a57f 100755 --- a/build/fbcode_builder/getdeps.py +++ b/build/fbcode_builder/getdeps.py @@ -826,10 +826,10 @@ jobs: # coupled with the boost manifest # This is the unusual syntax for setting an env var for the rest of # the steps in a workflow: - # https://help.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable + # https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ out.write(" - name: Export boost environment\n") out.write( - ' run: "echo ::set-env name=BOOST_ROOT::%BOOST_ROOT_1_69_0%"\n' + ' run: "echo BOOST_ROOT=%BOOST_ROOT_1_69_0% >> %GITHUB_ENV%"\n' ) out.write(" shell: cmd\n")