mirror of
https://github.com/facebookincubator/mvfst.git
synced 2025-08-09 20:42:44 +03:00
Summary: Previously, we maintained state and counters to count both, header and body bytes together. This commit introduces additional counters and state to keep track of just the body bytes that were sent and acked etc. Body bytes received will be implemented later. Reviewed By: bschlinker Differential Revision: D27312049 fbshipit-source-id: 33f169c9168dfda625e86de45df7c00d1897ba7e
774 lines
29 KiB
C++
774 lines
29 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
*/
|
|
|
|
#include <gmock/gmock.h>
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <quic/common/test/TestUtils.h>
|
|
#include <quic/fizz/server/handshake/FizzServerQuicHandshakeContext.h>
|
|
#include <quic/server/state/ServerStateMachine.h>
|
|
#include <quic/state/QuicStateFunctions.h>
|
|
#include <quic/state/stream/StreamReceiveHandlers.h>
|
|
#include <quic/state/stream/StreamSendHandlers.h>
|
|
#include <quic/state/test/Mocks.h>
|
|
|
|
using namespace testing;
|
|
|
|
namespace quic {
|
|
namespace test {
|
|
|
|
bool verifyToAckImmediately(
|
|
const QuicConnectionStateBase& conn,
|
|
const AckState& ackState) {
|
|
return !conn.pendingEvents.scheduleAckTimeout &&
|
|
ackState.needsToSendAckImmediately && ackState.numRxPacketsRecvd == 0 &&
|
|
ackState.numNonRxPacketsRecvd == 0;
|
|
}
|
|
|
|
bool verifyToScheduleAckTimeout(const QuicConnectionStateBase& conn) {
|
|
return conn.pendingEvents.scheduleAckTimeout;
|
|
}
|
|
|
|
RegularQuicWritePacket makeTestShortPacket() {
|
|
ShortHeader header(
|
|
ProtectionType::KeyPhaseZero, getTestConnectionId(), 2 /* packetNum */);
|
|
RegularQuicWritePacket packet(std::move(header));
|
|
return packet;
|
|
}
|
|
|
|
RegularQuicWritePacket makeTestLongPacket(LongHeader::Types type) {
|
|
LongHeader header(
|
|
type,
|
|
getTestConnectionId(0),
|
|
getTestConnectionId(1),
|
|
2 /* packetNum */,
|
|
QuicVersion::QUIC_DRAFT);
|
|
RegularQuicWritePacket packet(std::move(header));
|
|
return packet;
|
|
}
|
|
|
|
class UpdateLargestReceivedPacketNumTest
|
|
: public TestWithParam<PacketNumberSpace> {};
|
|
|
|
TEST_P(UpdateLargestReceivedPacketNumTest, ReceiveNew) {
|
|
QuicServerConnectionState conn(
|
|
FizzServerQuicHandshakeContext::Builder().build());
|
|
getAckState(conn, GetParam()).largestReceivedPacketNum = 100;
|
|
auto currentLargestReceived =
|
|
*getAckState(conn, GetParam()).largestReceivedPacketNum;
|
|
PacketNum newReceived = currentLargestReceived + 1;
|
|
updateLargestReceivedPacketNum(
|
|
getAckState(conn, GetParam()), newReceived, Clock::now());
|
|
EXPECT_GT(
|
|
*getAckState(conn, GetParam()).largestReceivedPacketNum,
|
|
currentLargestReceived);
|
|
}
|
|
|
|
TEST_P(UpdateLargestReceivedPacketNumTest, ReceiveOld) {
|
|
QuicServerConnectionState conn(
|
|
FizzServerQuicHandshakeContext::Builder().build());
|
|
getAckState(conn, GetParam()).largestReceivedPacketNum = 100;
|
|
auto currentLargestReceived =
|
|
*getAckState(conn, GetParam()).largestReceivedPacketNum;
|
|
PacketNum newReceived = currentLargestReceived - 1;
|
|
updateLargestReceivedPacketNum(
|
|
getAckState(conn, GetParam()), newReceived, Clock::now());
|
|
EXPECT_EQ(
|
|
*getAckState(conn, GetParam()).largestReceivedPacketNum,
|
|
currentLargestReceived);
|
|
}
|
|
|
|
INSTANTIATE_TEST_CASE_P(
|
|
UpdateLargestReceivedPacketNumTests,
|
|
UpdateLargestReceivedPacketNumTest,
|
|
Values(
|
|
PacketNumberSpace::Initial,
|
|
PacketNumberSpace::Handshake,
|
|
PacketNumberSpace::AppData));
|
|
|
|
class UpdateAckStateTest : public TestWithParam<PacketNumberSpace> {};
|
|
|
|
TEST_P(UpdateAckStateTest, TestUpdateAckState) {
|
|
QuicServerConnectionState conn(
|
|
FizzServerQuicHandshakeContext::Builder().build());
|
|
PacketNum nextPacketNum = 0;
|
|
auto& ackState = getAckState(conn, GetParam());
|
|
updateAckState(conn, GetParam(), nextPacketNum++, true, false, Clock::now());
|
|
EXPECT_EQ(ackState.acks.size(), 1);
|
|
EXPECT_EQ(ackState.acks.front().start, 0);
|
|
EXPECT_EQ(ackState.acks.front().end, 0);
|
|
EXPECT_FALSE(ackState.needsToSendAckImmediately);
|
|
EXPECT_EQ(ackState.numRxPacketsRecvd, 1);
|
|
EXPECT_TRUE(conn.pendingEvents.scheduleAckTimeout);
|
|
|
|
conn.pendingEvents.scheduleAckTimeout = false;
|
|
updateAckState(conn, GetParam(), nextPacketNum++, true, false, Clock::now());
|
|
EXPECT_EQ(ackState.acks.size(), 1);
|
|
EXPECT_EQ(ackState.acks.front().start, 0);
|
|
EXPECT_EQ(ackState.acks.front().end, 1);
|
|
EXPECT_FALSE(ackState.needsToSendAckImmediately);
|
|
EXPECT_EQ(ackState.numRxPacketsRecvd, 2);
|
|
EXPECT_TRUE(conn.pendingEvents.scheduleAckTimeout);
|
|
|
|
// Have a gap for next packet
|
|
nextPacketNum += 2;
|
|
conn.pendingEvents.scheduleAckTimeout = false;
|
|
updateAckState(conn, GetParam(), nextPacketNum++, true, false, Clock::now());
|
|
EXPECT_EQ(ackState.acks.size(), 2);
|
|
EXPECT_EQ(ackState.acks.front().start, 0);
|
|
EXPECT_EQ(ackState.acks.front().end, 1);
|
|
EXPECT_EQ(ackState.acks.back().start, 4);
|
|
EXPECT_EQ(ackState.acks.back().end, 4);
|
|
EXPECT_TRUE(ackState.needsToSendAckImmediately);
|
|
EXPECT_EQ(0, ackState.numRxPacketsRecvd);
|
|
EXPECT_FALSE(conn.pendingEvents.scheduleAckTimeout);
|
|
ackState.needsToSendAckImmediately = false;
|
|
conn.pendingEvents.scheduleAckTimeout = false;
|
|
|
|
// Reaching retx limit
|
|
for (uint8_t i = 0;
|
|
i < conn.transportSettings.rxPacketsBeforeAckBeforeInit - 1;
|
|
++i) {
|
|
updateAckState(
|
|
conn, GetParam(), nextPacketNum++, true, false, Clock::now());
|
|
EXPECT_FALSE(ackState.needsToSendAckImmediately);
|
|
EXPECT_TRUE(conn.pendingEvents.scheduleAckTimeout);
|
|
EXPECT_EQ(ackState.numRxPacketsRecvd, i + 1);
|
|
}
|
|
// Hit the limit
|
|
updateAckState(conn, GetParam(), nextPacketNum++, true, false, Clock::now());
|
|
// Should send ack immediately once we have
|
|
// conn.transportSettings.rxPacketsBeforeAckBeforeInit retransmittable packets
|
|
EXPECT_TRUE(ackState.needsToSendAckImmediately);
|
|
EXPECT_FALSE(conn.pendingEvents.scheduleAckTimeout);
|
|
|
|
ackState.needsToSendAckImmediately = false;
|
|
conn.pendingEvents.scheduleAckTimeout = false;
|
|
|
|
// Nonrx limit
|
|
for (uint64_t i = 0; i < kNonRtxRxPacketsPendingBeforeAck; ++i) {
|
|
EXPECT_FALSE(ackState.needsToSendAckImmediately);
|
|
EXPECT_EQ(ackState.numNonRxPacketsRecvd, i);
|
|
updateAckState(
|
|
conn, GetParam(), nextPacketNum++, false, false, Clock::now());
|
|
}
|
|
// Should send ack immediately once we have
|
|
// kNonRtxRxPacketsPendingBeforeAck non retransmittable packets
|
|
EXPECT_TRUE(ackState.needsToSendAckImmediately);
|
|
// Non-rx packets don't turn on Ack timer:
|
|
EXPECT_FALSE(conn.pendingEvents.scheduleAckTimeout);
|
|
|
|
ackState.needsToSendAckImmediately = false;
|
|
|
|
// Crypto always triggers immediately ack:
|
|
updateAckState(conn, GetParam(), nextPacketNum++, true, true, Clock::now());
|
|
EXPECT_TRUE(ackState.needsToSendAckImmediately);
|
|
EXPECT_FALSE(conn.pendingEvents.scheduleAckTimeout);
|
|
}
|
|
|
|
TEST_P(UpdateAckStateTest, TestUpdateAckStateFrequency) {
|
|
QuicServerConnectionState conn(
|
|
FizzServerQuicHandshakeContext::Builder().build());
|
|
conn.transportSettings.rxPacketsBeforeAckInitThreshold = 20;
|
|
conn.transportSettings.rxPacketsBeforeAckBeforeInit = 2;
|
|
conn.transportSettings.rxPacketsBeforeAckAfterInit = 10;
|
|
PacketNum nextPacketNum = 0;
|
|
auto& ackState = getAckState(conn, GetParam());
|
|
|
|
for (uint8_t i = 0;
|
|
i < conn.transportSettings.rxPacketsBeforeAckBeforeInit - 1;
|
|
++i) {
|
|
updateAckState(
|
|
conn, GetParam(), nextPacketNum++, true, false, Clock::now());
|
|
EXPECT_FALSE(ackState.needsToSendAckImmediately);
|
|
EXPECT_TRUE(conn.pendingEvents.scheduleAckTimeout);
|
|
EXPECT_EQ(ackState.numRxPacketsRecvd, i + 1);
|
|
}
|
|
updateAckState(conn, GetParam(), nextPacketNum++, true, false, Clock::now());
|
|
EXPECT_TRUE(ackState.needsToSendAckImmediately);
|
|
EXPECT_FALSE(conn.pendingEvents.scheduleAckTimeout);
|
|
ackState.needsToSendAckImmediately = false;
|
|
conn.pendingEvents.scheduleAckTimeout = false;
|
|
|
|
for (;
|
|
nextPacketNum <= conn.transportSettings.rxPacketsBeforeAckInitThreshold;
|
|
nextPacketNum++) {
|
|
updateAckState(conn, GetParam(), nextPacketNum, true, false, Clock::now());
|
|
}
|
|
ASSERT_EQ(
|
|
ackState.largestReceivedPacketNum.value(),
|
|
conn.transportSettings.rxPacketsBeforeAckInitThreshold);
|
|
ackState.needsToSendAckImmediately = false;
|
|
conn.pendingEvents.scheduleAckTimeout = false;
|
|
ackState.numRxPacketsRecvd = 0;
|
|
for (uint8_t i = 0;
|
|
i < conn.transportSettings.rxPacketsBeforeAckAfterInit - 1;
|
|
++i) {
|
|
updateAckState(
|
|
conn, GetParam(), nextPacketNum++, true, false, Clock::now());
|
|
EXPECT_FALSE(ackState.needsToSendAckImmediately);
|
|
EXPECT_TRUE(conn.pendingEvents.scheduleAckTimeout);
|
|
EXPECT_EQ(ackState.numRxPacketsRecvd, i + 1);
|
|
}
|
|
updateAckState(conn, GetParam(), nextPacketNum++, true, false, Clock::now());
|
|
EXPECT_TRUE(ackState.needsToSendAckImmediately);
|
|
EXPECT_FALSE(conn.pendingEvents.scheduleAckTimeout);
|
|
}
|
|
|
|
TEST_P(UpdateAckStateTest, TestUpdateAckStateFrequencyFromTolerance) {
|
|
QuicServerConnectionState conn(
|
|
FizzServerQuicHandshakeContext::Builder().build());
|
|
PacketNum nextPacketNum = 1;
|
|
auto& ackState = getAckState(conn, GetParam());
|
|
ackState.largestReceivedPacketNum = nextPacketNum - 1;
|
|
ackState.tolerance = 2;
|
|
for (nextPacketNum; nextPacketNum <= 10; nextPacketNum++) {
|
|
updateAckState(conn, GetParam(), nextPacketNum, true, false, Clock::now());
|
|
if (nextPacketNum % 2 == 0) {
|
|
EXPECT_TRUE(ackState.needsToSendAckImmediately);
|
|
EXPECT_FALSE(conn.pendingEvents.scheduleAckTimeout);
|
|
} else {
|
|
EXPECT_FALSE(ackState.needsToSendAckImmediately);
|
|
EXPECT_TRUE(conn.pendingEvents.scheduleAckTimeout);
|
|
}
|
|
EXPECT_EQ(ackState.numRxPacketsRecvd, nextPacketNum % 2);
|
|
}
|
|
ackState.tolerance = 10;
|
|
for (nextPacketNum; nextPacketNum <= 40; nextPacketNum++) {
|
|
updateAckState(conn, GetParam(), nextPacketNum, true, false, Clock::now());
|
|
if (nextPacketNum % 10 == 0) {
|
|
EXPECT_TRUE(ackState.needsToSendAckImmediately);
|
|
EXPECT_FALSE(conn.pendingEvents.scheduleAckTimeout);
|
|
} else {
|
|
EXPECT_FALSE(ackState.needsToSendAckImmediately);
|
|
EXPECT_TRUE(conn.pendingEvents.scheduleAckTimeout);
|
|
}
|
|
EXPECT_EQ(ackState.numRxPacketsRecvd, nextPacketNum % 10);
|
|
}
|
|
}
|
|
|
|
TEST_F(UpdateAckStateTest, UpdateAckStateOnAckTimeout) {
|
|
QuicConnectionStateBase conn(QuicNodeType::Client);
|
|
auto& initialAckState = getAckState(conn, PacketNumberSpace::Initial);
|
|
auto& handshakeAckState = getAckState(conn, PacketNumberSpace::Handshake);
|
|
auto& appDataAckState = getAckState(conn, PacketNumberSpace::AppData);
|
|
initialAckState.numRxPacketsRecvd = 1;
|
|
handshakeAckState.numRxPacketsRecvd = 2;
|
|
appDataAckState.numRxPacketsRecvd = 3;
|
|
initialAckState.numNonRxPacketsRecvd = 4;
|
|
handshakeAckState.numNonRxPacketsRecvd = 5;
|
|
appDataAckState.numNonRxPacketsRecvd = 6;
|
|
|
|
updateAckStateOnAckTimeout(conn);
|
|
|
|
EXPECT_TRUE(appDataAckState.needsToSendAckImmediately);
|
|
EXPECT_FALSE(conn.pendingEvents.scheduleAckTimeout);
|
|
EXPECT_EQ(0, appDataAckState.numRxPacketsRecvd);
|
|
EXPECT_EQ(0, appDataAckState.numNonRxPacketsRecvd);
|
|
|
|
EXPECT_FALSE(initialAckState.needsToSendAckImmediately);
|
|
EXPECT_EQ(1, initialAckState.numRxPacketsRecvd);
|
|
EXPECT_EQ(4, initialAckState.numNonRxPacketsRecvd);
|
|
|
|
EXPECT_FALSE(handshakeAckState.needsToSendAckImmediately);
|
|
EXPECT_FALSE(conn.pendingEvents.scheduleAckTimeout);
|
|
EXPECT_EQ(2, handshakeAckState.numRxPacketsRecvd);
|
|
EXPECT_EQ(5, handshakeAckState.numNonRxPacketsRecvd);
|
|
}
|
|
|
|
TEST_P(UpdateAckStateTest, UpdateAckSendStateOnRecvPacketsCrypto) {
|
|
// Crypto always leads to immediate ack
|
|
QuicConnectionStateBase conn(QuicNodeType::Client);
|
|
auto& ackState = getAckState(conn, GetParam());
|
|
updateAckSendStateOnRecvPacket(conn, ackState, false, true, true);
|
|
EXPECT_TRUE(verifyToAckImmediately(conn, ackState));
|
|
EXPECT_FALSE(verifyToScheduleAckTimeout(conn));
|
|
}
|
|
|
|
TEST_P(UpdateAckStateTest, UpdateAckSendStateOnRecvPacketsRxLimit) {
|
|
// Retx packets reach thresh
|
|
QuicConnectionStateBase conn(QuicNodeType::Client);
|
|
auto& ackState = getAckState(conn, GetParam());
|
|
for (size_t i = 0;
|
|
i < conn.transportSettings.rxPacketsBeforeAckBeforeInit - 1;
|
|
i++) {
|
|
updateAckSendStateOnRecvPacket(conn, ackState, false, true, false);
|
|
EXPECT_FALSE(verifyToAckImmediately(conn, ackState));
|
|
EXPECT_TRUE(verifyToScheduleAckTimeout(conn));
|
|
}
|
|
updateAckSendStateOnRecvPacket(conn, ackState, false, true, false);
|
|
EXPECT_TRUE(verifyToAckImmediately(conn, ackState));
|
|
EXPECT_FALSE(verifyToScheduleAckTimeout(conn));
|
|
// Ack one more, we will start counting again
|
|
updateAckSendStateOnRecvPacket(conn, ackState, false, true, false);
|
|
EXPECT_FALSE(verifyToAckImmediately(conn, ackState));
|
|
EXPECT_TRUE(verifyToScheduleAckTimeout(conn));
|
|
}
|
|
|
|
TEST_P(UpdateAckStateTest, UpdateAckSendStateOnRecvPacketsNonRxLimit) {
|
|
// Non-rx packets reach thresh
|
|
QuicConnectionStateBase conn(QuicNodeType::Client);
|
|
auto& ackState = getAckState(conn, GetParam());
|
|
for (size_t i = 0; i < kNonRtxRxPacketsPendingBeforeAck - 1; i++) {
|
|
updateAckSendStateOnRecvPacket(conn, ackState, false, false, false);
|
|
EXPECT_FALSE(verifyToAckImmediately(conn, ackState));
|
|
EXPECT_FALSE(verifyToScheduleAckTimeout(conn));
|
|
}
|
|
updateAckSendStateOnRecvPacket(conn, ackState, false, false, false);
|
|
EXPECT_TRUE(verifyToAckImmediately(conn, ackState));
|
|
EXPECT_FALSE(verifyToScheduleAckTimeout(conn));
|
|
// Ack one more, we will start counting again
|
|
updateAckSendStateOnRecvPacket(conn, ackState, false, false, false);
|
|
EXPECT_FALSE(verifyToAckImmediately(conn, ackState));
|
|
EXPECT_FALSE(verifyToScheduleAckTimeout(conn));
|
|
}
|
|
|
|
TEST_P(
|
|
UpdateAckStateTest,
|
|
UpdateAckSendStateOnRecvPacketsNonRxLimitWithRxPackets) {
|
|
// Non-rx packets reach thresh
|
|
QuicConnectionStateBase conn(QuicNodeType::Client);
|
|
auto& ackState = getAckState(conn, GetParam());
|
|
// use 1 rx packet
|
|
updateAckSendStateOnRecvPacket(conn, ackState, false, true, false);
|
|
for (size_t i = 0;
|
|
i < conn.transportSettings.rxPacketsBeforeAckBeforeInit - 2;
|
|
i++) {
|
|
updateAckSendStateOnRecvPacket(conn, ackState, false, false, false);
|
|
EXPECT_FALSE(verifyToAckImmediately(conn, ackState));
|
|
EXPECT_TRUE(verifyToScheduleAckTimeout(conn));
|
|
}
|
|
updateAckSendStateOnRecvPacket(conn, ackState, false, false, false);
|
|
EXPECT_TRUE(verifyToAckImmediately(conn, ackState));
|
|
EXPECT_FALSE(verifyToScheduleAckTimeout(conn));
|
|
// Ack one more, we will start counting again
|
|
updateAckSendStateOnRecvPacket(conn, ackState, false, false, false);
|
|
EXPECT_FALSE(verifyToAckImmediately(conn, ackState));
|
|
EXPECT_FALSE(verifyToScheduleAckTimeout(conn));
|
|
}
|
|
|
|
TEST_P(UpdateAckStateTest, UpdateAckSendStateOnRecvPacketsRxAndNonRxMixed) {
|
|
// Rx and non-rx mixed together. We should still just need
|
|
// conn.transportSettings.rxPacketsBeforeAckBeforeInit to trigger an ack
|
|
QuicConnectionStateBase conn(QuicNodeType::Client);
|
|
auto& ackState = getAckState(conn, GetParam());
|
|
for (size_t i = 0;
|
|
i < conn.transportSettings.rxPacketsBeforeAckBeforeInit - 1;
|
|
i++) {
|
|
bool isRetransmittable = i % 2;
|
|
updateAckSendStateOnRecvPacket(
|
|
conn, ackState, false, isRetransmittable, false);
|
|
EXPECT_FALSE(verifyToAckImmediately(conn, ackState));
|
|
EXPECT_EQ(i >= 1, verifyToScheduleAckTimeout(conn));
|
|
}
|
|
updateAckSendStateOnRecvPacket(conn, ackState, false, true, false);
|
|
EXPECT_TRUE(verifyToAckImmediately(conn, ackState));
|
|
EXPECT_FALSE(verifyToScheduleAckTimeout(conn));
|
|
// Ack one more, we will start counting again
|
|
updateAckSendStateOnRecvPacket(conn, ackState, false, true, false);
|
|
EXPECT_FALSE(verifyToAckImmediately(conn, ackState));
|
|
EXPECT_TRUE(verifyToScheduleAckTimeout(conn));
|
|
}
|
|
|
|
TEST_P(UpdateAckStateTest, UpdateAckSendStateOnRecvPacketsRxOutOfOrder) {
|
|
// Retransmittable & out of order: ack immediately
|
|
QuicConnectionStateBase conn(QuicNodeType::Client);
|
|
auto& ackState = getAckState(conn, GetParam());
|
|
updateAckSendStateOnRecvPacket(conn, ackState, true, true, false);
|
|
EXPECT_TRUE(verifyToAckImmediately(conn, ackState));
|
|
EXPECT_FALSE(verifyToScheduleAckTimeout(conn));
|
|
}
|
|
|
|
TEST_P(UpdateAckStateTest, UpdateAckSendStateOnRecvPacketsRxOutOfOrderIgnore) {
|
|
// Retransmittable & out of order: don't ack immediately if ignoring order.
|
|
QuicConnectionStateBase conn(QuicNodeType::Client);
|
|
auto& ackState = getAckState(conn, GetParam());
|
|
ackState.ignoreReorder = true;
|
|
updateAckSendStateOnRecvPacket(conn, ackState, true, true, false);
|
|
EXPECT_FALSE(verifyToAckImmediately(conn, ackState));
|
|
EXPECT_TRUE(verifyToScheduleAckTimeout(conn));
|
|
}
|
|
|
|
TEST_P(UpdateAckStateTest, UpdateAckSendStateOnRecvPacketsNonRxOutOfOrder) {
|
|
// Non-retransmittable & out of order: not ack immediately
|
|
QuicConnectionStateBase conn(QuicNodeType::Client);
|
|
auto& ackState = getAckState(conn, GetParam());
|
|
updateAckSendStateOnRecvPacket(conn, ackState, true, false, false);
|
|
EXPECT_FALSE(verifyToAckImmediately(conn, ackState));
|
|
EXPECT_FALSE(verifyToScheduleAckTimeout(conn));
|
|
}
|
|
|
|
INSTANTIATE_TEST_CASE_P(
|
|
UpdateAckStateTests,
|
|
UpdateAckStateTest,
|
|
Values(
|
|
PacketNumberSpace::Initial,
|
|
PacketNumberSpace::Handshake,
|
|
PacketNumberSpace::AppData));
|
|
|
|
class QuicStateFunctionsTest : public TestWithParam<PacketNumberSpace> {};
|
|
|
|
TEST_F(QuicStateFunctionsTest, RttCalculationNoAckDelay) {
|
|
QuicServerConnectionState conn(
|
|
FizzServerQuicHandshakeContext::Builder().build());
|
|
auto rttSample = 1100us;
|
|
updateRtt(conn, rttSample, 0us);
|
|
EXPECT_EQ(1100, conn.lossState.srtt.count());
|
|
EXPECT_EQ(1100 / 2, conn.lossState.rttvar.count());
|
|
EXPECT_EQ(0us, conn.lossState.maxAckDelay);
|
|
}
|
|
|
|
TEST_F(QuicStateFunctionsTest, RttCalculationWithAckDelay) {
|
|
QuicServerConnectionState conn(
|
|
FizzServerQuicHandshakeContext::Builder().build());
|
|
auto rttSample = 1000us;
|
|
updateRtt(conn, rttSample, 300us);
|
|
EXPECT_EQ(700, conn.lossState.srtt.count());
|
|
EXPECT_EQ(700, conn.lossState.lrtt.count());
|
|
EXPECT_EQ(1000, conn.lossState.mrtt.count());
|
|
EXPECT_EQ(350, conn.lossState.rttvar.count());
|
|
EXPECT_EQ(300us, conn.lossState.maxAckDelay);
|
|
}
|
|
|
|
TEST_F(QuicStateFunctionsTest, RttCalculationWithMrttAckDelay) {
|
|
QuicServerConnectionState conn(
|
|
FizzServerQuicHandshakeContext::Builder().build());
|
|
conn.lossState.mrtt = 100us;
|
|
auto rttSample = 1000us;
|
|
updateRtt(conn, rttSample, 300us);
|
|
EXPECT_EQ(700, conn.lossState.srtt.count());
|
|
EXPECT_EQ(700, conn.lossState.lrtt.count());
|
|
EXPECT_EQ(100, conn.lossState.mrtt.count());
|
|
EXPECT_EQ(350, conn.lossState.rttvar.count());
|
|
EXPECT_EQ(300us, conn.lossState.maxAckDelay);
|
|
}
|
|
|
|
TEST_F(QuicStateFunctionsTest, RttCalculationIgnoreAckDelay) {
|
|
QuicServerConnectionState conn(
|
|
FizzServerQuicHandshakeContext::Builder().build());
|
|
conn.lossState.mrtt = 700us;
|
|
auto rttSample = 900us;
|
|
updateRtt(conn, rttSample, 300us);
|
|
EXPECT_EQ(900, conn.lossState.srtt.count());
|
|
EXPECT_EQ(900, conn.lossState.lrtt.count());
|
|
EXPECT_EQ(700, conn.lossState.mrtt.count());
|
|
EXPECT_EQ(450, conn.lossState.rttvar.count());
|
|
EXPECT_EQ(300us, conn.lossState.maxAckDelay);
|
|
}
|
|
|
|
TEST_F(QuicStateFunctionsTest, RttCalculationAckDelayLarger) {
|
|
QuicServerConnectionState conn(
|
|
FizzServerQuicHandshakeContext::Builder().build());
|
|
auto rttSample = 10us;
|
|
updateRtt(conn, rttSample, 300us);
|
|
EXPECT_EQ(10, conn.lossState.srtt.count());
|
|
EXPECT_EQ(10, conn.lossState.lrtt.count());
|
|
EXPECT_EQ(10, conn.lossState.mrtt.count());
|
|
EXPECT_EQ(5, conn.lossState.rttvar.count());
|
|
EXPECT_EQ(300us, conn.lossState.maxAckDelay);
|
|
}
|
|
|
|
TEST_F(QuicStateFunctionsTest, TestInvokeStreamStateMachineConnectionError) {
|
|
QuicServerConnectionState conn(
|
|
FizzServerQuicHandshakeContext::Builder().build());
|
|
QuicStreamState stream(1, conn);
|
|
RstStreamFrame rst(1, GenericApplicationErrorCode::UNKNOWN, 100);
|
|
stream.finalReadOffset = 1024;
|
|
EXPECT_THROW(
|
|
receiveRstStreamSMHandler(stream, std::move(rst)),
|
|
QuicTransportException);
|
|
// This doesn't change the send state machine implicitly anymore
|
|
bool matches = (stream.sendState == StreamSendState::Open);
|
|
EXPECT_TRUE(matches);
|
|
}
|
|
|
|
TEST_F(QuicStateFunctionsTest, InvokeResetDoesNotSendFlowControl) {
|
|
QuicServerConnectionState conn(
|
|
FizzServerQuicHandshakeContext::Builder().build());
|
|
QuicStreamState stream(1, conn);
|
|
RstStreamFrame rst(1, GenericApplicationErrorCode::UNKNOWN, 90);
|
|
// this would normally trigger a flow control update.
|
|
stream.flowControlState.advertisedMaxOffset = 100;
|
|
stream.flowControlState.windowSize = 100;
|
|
conn.flowControlState.advertisedMaxOffset = 100;
|
|
conn.flowControlState.windowSize = 100;
|
|
receiveRstStreamSMHandler(stream, std::move(rst));
|
|
bool matches = (stream.recvState == StreamRecvState::Closed);
|
|
EXPECT_TRUE(matches);
|
|
EXPECT_FALSE(conn.streamManager->hasWindowUpdates());
|
|
EXPECT_TRUE(conn.pendingEvents.connWindowUpdate);
|
|
}
|
|
|
|
TEST_F(QuicStateFunctionsTest, TestInvokeStreamStateMachineStreamError) {
|
|
// We isolate invalid events on streams to affect only the streams. Is that
|
|
// a good idea? We'll find out.
|
|
QuicServerConnectionState conn(
|
|
FizzServerQuicHandshakeContext::Builder().build());
|
|
QuicStreamState stream(1, conn);
|
|
RstStreamFrame rst(1, GenericApplicationErrorCode::UNKNOWN, 100);
|
|
try {
|
|
sendRstAckSMHandler(stream);
|
|
ADD_FAILURE();
|
|
} catch (QuicTransportException& ex) {
|
|
EXPECT_EQ(ex.errorCode(), TransportErrorCode::STREAM_STATE_ERROR);
|
|
}
|
|
bool matches = (stream.sendState == StreamSendState::Open);
|
|
EXPECT_TRUE(matches);
|
|
}
|
|
|
|
TEST_F(QuicStateFunctionsTest, UpdateMinRtt) {
|
|
QuicServerConnectionState conn(
|
|
FizzServerQuicHandshakeContext::Builder().build());
|
|
auto qLogger = std::make_shared<FileQLogger>(VantagePoint::Server);
|
|
conn.qLogger = qLogger;
|
|
|
|
// First rtt sample, will be assign to both srtt and mrtt
|
|
auto rttSample = 100us;
|
|
updateRtt(conn, rttSample, 0us);
|
|
EXPECT_EQ(100us, conn.lossState.lrtt);
|
|
EXPECT_EQ(conn.lossState.lrtt, conn.lossState.mrtt);
|
|
EXPECT_EQ(conn.lossState.lrtt, conn.lossState.srtt);
|
|
auto oldMrtt = conn.lossState.mrtt;
|
|
|
|
// Slower packet
|
|
rttSample = 550us;
|
|
updateRtt(conn, rttSample, 0us);
|
|
EXPECT_EQ(oldMrtt, conn.lossState.mrtt);
|
|
|
|
// Faster packet
|
|
rttSample = 20us;
|
|
updateRtt(conn, rttSample, 0us);
|
|
EXPECT_EQ(20us, conn.lossState.mrtt);
|
|
|
|
std::vector<int> indices =
|
|
getQLogEventIndices(QLogEventType::MetricUpdate, qLogger);
|
|
EXPECT_EQ(indices.size(), 3);
|
|
std::array<std::chrono::microseconds, 3> rttSampleArr = {100us, 550us, 20us};
|
|
std::array<std::chrono::microseconds, 3> mrttArr = {oldMrtt, oldMrtt, 20us};
|
|
std::array<std::chrono::microseconds, 3> srttArr = {100us, 155us, 137us};
|
|
|
|
for (int i = 0; i < 3; ++i) {
|
|
auto tmp = std::move(qLogger->logs[indices[i]]);
|
|
auto event = dynamic_cast<QLogMetricUpdateEvent*>(tmp.get());
|
|
EXPECT_EQ(event->latestRtt, rttSampleArr[i]);
|
|
EXPECT_EQ(event->mrtt, mrttArr[i]);
|
|
EXPECT_EQ(event->srtt, srttArr[i]);
|
|
EXPECT_EQ(event->ackDelay, 0us);
|
|
}
|
|
}
|
|
|
|
TEST_F(QuicStateFunctionsTest, UpdateMaxAckDelay) {
|
|
QuicServerConnectionState conn(
|
|
FizzServerQuicHandshakeContext::Builder().build());
|
|
EXPECT_EQ(0us, conn.lossState.maxAckDelay);
|
|
auto rttSample = 100us;
|
|
|
|
// update maxAckDelay
|
|
updateRtt(conn, rttSample, 30us);
|
|
EXPECT_EQ(30us, conn.lossState.maxAckDelay);
|
|
|
|
// smaller ackDelay
|
|
updateRtt(conn, rttSample, 3us);
|
|
EXPECT_EQ(30us, conn.lossState.maxAckDelay);
|
|
}
|
|
|
|
TEST_F(QuicStateFunctionsTest, IsConnectionPaced) {
|
|
QuicConnectionStateBase state(QuicNodeType::Client);
|
|
EXPECT_FALSE(isConnectionPaced(state));
|
|
|
|
state.canBePaced = true;
|
|
EXPECT_FALSE(isConnectionPaced(state));
|
|
|
|
state.transportSettings.pacingEnabled = true;
|
|
EXPECT_FALSE(isConnectionPaced(state));
|
|
}
|
|
|
|
TEST_F(QuicStateFunctionsTest, GetOutstandingPackets) {
|
|
QuicConnectionStateBase conn(QuicNodeType::Client);
|
|
conn.outstandings.packets.emplace_back(
|
|
makeTestLongPacket(LongHeader::Types::Initial),
|
|
Clock::now(),
|
|
135,
|
|
0,
|
|
false,
|
|
0,
|
|
0,
|
|
0,
|
|
0,
|
|
LossState());
|
|
conn.outstandings.packets.emplace_back(
|
|
makeTestLongPacket(LongHeader::Types::Handshake),
|
|
Clock::now(),
|
|
1217,
|
|
0,
|
|
false,
|
|
0,
|
|
0,
|
|
0,
|
|
0,
|
|
LossState());
|
|
conn.outstandings.packets.emplace_back(
|
|
makeTestShortPacket(),
|
|
Clock::now(),
|
|
5556,
|
|
5000,
|
|
false,
|
|
0,
|
|
0,
|
|
0,
|
|
0,
|
|
LossState());
|
|
conn.outstandings.packets.emplace_back(
|
|
makeTestLongPacket(LongHeader::Types::Initial),
|
|
Clock::now(),
|
|
56,
|
|
0,
|
|
false,
|
|
0,
|
|
0,
|
|
0,
|
|
0,
|
|
LossState());
|
|
conn.outstandings.packets.emplace_back(
|
|
makeTestShortPacket(),
|
|
Clock::now(),
|
|
6665,
|
|
6000,
|
|
false,
|
|
0,
|
|
0,
|
|
0,
|
|
0,
|
|
LossState());
|
|
EXPECT_EQ(
|
|
135,
|
|
getFirstOutstandingPacket(conn, PacketNumberSpace::Initial)
|
|
->metadata.encodedSize);
|
|
EXPECT_EQ(
|
|
0,
|
|
getFirstOutstandingPacket(conn, PacketNumberSpace::Initial)
|
|
->metadata.encodedBodySize);
|
|
EXPECT_EQ(
|
|
56,
|
|
getLastOutstandingPacket(conn, PacketNumberSpace::Initial)
|
|
->metadata.encodedSize);
|
|
EXPECT_EQ(
|
|
0,
|
|
getLastOutstandingPacket(conn, PacketNumberSpace::Initial)
|
|
->metadata.encodedBodySize);
|
|
EXPECT_EQ(
|
|
1217,
|
|
getFirstOutstandingPacket(conn, PacketNumberSpace::Handshake)
|
|
->metadata.encodedSize);
|
|
EXPECT_EQ(
|
|
0,
|
|
getFirstOutstandingPacket(conn, PacketNumberSpace::Handshake)
|
|
->metadata.encodedBodySize);
|
|
EXPECT_EQ(
|
|
5556,
|
|
getFirstOutstandingPacket(conn, PacketNumberSpace::AppData)
|
|
->metadata.encodedSize);
|
|
EXPECT_EQ(
|
|
5000,
|
|
getFirstOutstandingPacket(conn, PacketNumberSpace::AppData)
|
|
->metadata.encodedBodySize);
|
|
EXPECT_EQ(
|
|
6665,
|
|
getLastOutstandingPacket(conn, PacketNumberSpace::AppData)
|
|
->metadata.encodedSize);
|
|
EXPECT_EQ(
|
|
6000,
|
|
getLastOutstandingPacket(conn, PacketNumberSpace::AppData)
|
|
->metadata.encodedBodySize);
|
|
}
|
|
|
|
TEST_F(QuicStateFunctionsTest, UpdateLargestReceivePacketsAtLatCloseSent) {
|
|
QuicConnectionStateBase conn(QuicNodeType::Client);
|
|
EXPECT_FALSE(conn.ackStates.initialAckState.largestReceivedAtLastCloseSent);
|
|
EXPECT_FALSE(conn.ackStates.handshakeAckState.largestReceivedAtLastCloseSent);
|
|
EXPECT_FALSE(conn.ackStates.appDataAckState.largestReceivedAtLastCloseSent);
|
|
conn.ackStates.initialAckState.largestReceivedPacketNum = 123;
|
|
conn.ackStates.handshakeAckState.largestReceivedPacketNum = 654;
|
|
conn.ackStates.appDataAckState.largestReceivedPacketNum = 789;
|
|
updateLargestReceivedPacketsAtLastCloseSent(conn);
|
|
EXPECT_EQ(
|
|
123, *conn.ackStates.initialAckState.largestReceivedAtLastCloseSent);
|
|
EXPECT_EQ(
|
|
654, *conn.ackStates.handshakeAckState.largestReceivedAtLastCloseSent);
|
|
EXPECT_EQ(
|
|
789, *conn.ackStates.appDataAckState.largestReceivedAtLastCloseSent);
|
|
}
|
|
|
|
TEST_P(QuicStateFunctionsTest, HasReceivedPackets) {
|
|
QuicConnectionStateBase conn(QuicNodeType::Server);
|
|
EXPECT_FALSE(hasReceivedPackets(conn));
|
|
getAckState(conn, GetParam()).largestReceivedPacketNum = 123;
|
|
EXPECT_TRUE(hasReceivedPackets(conn));
|
|
}
|
|
|
|
TEST_P(QuicStateFunctionsTest, HasReceivedPacketsAtLastCloseSent) {
|
|
QuicConnectionStateBase conn(QuicNodeType::Server);
|
|
EXPECT_FALSE(hasReceivedPacketsAtLastCloseSent(conn));
|
|
getAckState(conn, GetParam()).largestReceivedAtLastCloseSent = 1;
|
|
EXPECT_TRUE(hasReceivedPacketsAtLastCloseSent(conn));
|
|
}
|
|
|
|
TEST_P(QuicStateFunctionsTest, HasNotReceivedNewPacketsSinceLastClose) {
|
|
QuicConnectionStateBase conn(QuicNodeType::Server);
|
|
EXPECT_TRUE(hasNotReceivedNewPacketsSinceLastCloseSent(conn));
|
|
getAckState(conn, GetParam()).largestReceivedPacketNum = 1;
|
|
EXPECT_FALSE(hasNotReceivedNewPacketsSinceLastCloseSent(conn));
|
|
getAckState(conn, GetParam()).largestReceivedAtLastCloseSent = 1;
|
|
EXPECT_TRUE(hasReceivedPacketsAtLastCloseSent(conn));
|
|
}
|
|
|
|
TEST_F(QuicStateFunctionsTest, EarliestLossTimer) {
|
|
QuicConnectionStateBase conn(QuicNodeType::Server);
|
|
EXPECT_FALSE(earliestLossTimer(conn).first.has_value());
|
|
auto currentTime = Clock::now();
|
|
|
|
// Before handshake completed
|
|
conn.lossState.lossTimes[PacketNumberSpace::Initial] = currentTime;
|
|
EXPECT_EQ(PacketNumberSpace::Initial, earliestLossTimer(conn).second);
|
|
EXPECT_EQ(currentTime, earliestLossTimer(conn).first.value());
|
|
conn.lossState.lossTimes[PacketNumberSpace::AppData] = currentTime - 2s;
|
|
EXPECT_EQ(PacketNumberSpace::Initial, earliestLossTimer(conn).second);
|
|
EXPECT_EQ(currentTime, earliestLossTimer(conn).first.value());
|
|
conn.lossState.lossTimes[PacketNumberSpace::Handshake] = currentTime - 1s;
|
|
EXPECT_EQ(PacketNumberSpace::Handshake, earliestLossTimer(conn).second);
|
|
EXPECT_EQ(currentTime - 1s, earliestLossTimer(conn).first.value());
|
|
|
|
conn.oneRttWriteCipher = createNoOpAead();
|
|
|
|
// After one-rtt cipher is available
|
|
EXPECT_EQ(PacketNumberSpace::AppData, earliestLossTimer(conn).second);
|
|
EXPECT_EQ(currentTime - 2s, earliestLossTimer(conn).first.value());
|
|
conn.lossState.lossTimes[PacketNumberSpace::AppData] = currentTime + 1s;
|
|
EXPECT_EQ(PacketNumberSpace::Handshake, earliestLossTimer(conn).second);
|
|
EXPECT_EQ(currentTime - 1s, earliestLossTimer(conn).first.value());
|
|
}
|
|
|
|
TEST_P(QuicStateFunctionsTest, CloseTranportStateChange) {
|
|
QuicConnectionStateBase conn(QuicNodeType::Server);
|
|
getAckState(conn, GetParam()).nextPacketNum = kMaxPacketNumber - 2;
|
|
EXPECT_FALSE(conn.pendingEvents.closeTransport);
|
|
increaseNextPacketNum(conn, GetParam());
|
|
EXPECT_TRUE(conn.pendingEvents.closeTransport);
|
|
}
|
|
|
|
INSTANTIATE_TEST_CASE_P(
|
|
QuicStateFunctionsTests,
|
|
QuicStateFunctionsTest,
|
|
Values(
|
|
PacketNumberSpace::Initial,
|
|
PacketNumberSpace::Handshake,
|
|
PacketNumberSpace::AppData));
|
|
|
|
} // namespace test
|
|
} // namespace quic
|